[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Łukasz Langa]

Łukasz Langa added the comment:

Oh, forgot about this exception, sorry! Thanks for the clarification.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

Reading PEP 434, special rules for IDLE, should mostly answer your question.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Łukasz Langa]

Łukasz Langa added the comment:

I don't understand why GH-3097 was introduced to 3.6.2. This doesn't look like 
a bugfix?

--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 764e282158df0d7d6d7e0c72f38756c979a36539 by Terry Jan Reedy 
(Cheryl Sabella) in branch '3.6':
[3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3141) (#3154)
https://github.com/python/cpython/commit/764e282158df0d7d6d7e0c72f38756c979a36539


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +3190

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset a32e40561a24de373d1c5a437a8aa329758ba8e4 by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-31206: IDLE: Factor HighPage class from ConfigDialog (#3141)
https://github.com/python/cpython/commit/a32e40561a24de373d1c5a437a8aa329758ba8e4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

The change to configdialog is basically a block move with a few edits.  The 
resulting diff is so complicated that git could not apply it cleanly to the 
identical code in 3.6.  We should do multiple PRs for the highlight group.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset ff4b222b029f9977a4509d8697ba2b82c09b477a by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-31205: IDLE: Factor KeysPage class from ConfigDialog (GH-3096) (#3097)
https://github.com/python/cpython/commit/ff4b222b029f9977a4509d8697ba2b82c09b477a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +3136

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset e36d9f5568093b3885da62a0bf0fdfbe3771672b by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-31205: IDLE: Factor KeysPage class from ConfigDialog (#3096)
https://github.com/python/cpython/commit/e36d9f5568093b3885da62a0bf0fdfbe3771672b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Cheryl Sabella]

Cheryl Sabella added the comment:

I ran into an issue with the three calls to functions in ConfigDialog 
(deactivate_current_config, activate_config_changes, and 
save_all_changed_extensions) from within the KeysPage class.  I tried to 
minimize the changes by just creating self.cd for the ConfigDialog instance.  
Besides that, the changes were the same as the FontPage and GenPage.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +3135

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Cheryl Sabella]

Cheryl Sabella added the comment:

I'll work on this today.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

Let me know if you start on this.

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

[Terry J. Reedy]

New submission from Terry J. Reedy:

Do as did with #31050 and GenPage class.  This should be done *before* #31001, 
highlights test.

--
assignee: terry.reedy
components: IDLE
messages: 300273
nosy: terry.reedy
priority: normal
severity: normal
stage: test needed
status: open
title: IDLE, configdialog: Factor out KeysPage class from ConfigDialog
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com