[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 146351860a34b3cde387930a360e57391e7b99f3 by Victor Stinner in 
branch '2.7':
[2.7] bpo-31234: Join threads explicitly in tests (#7406)
https://github.com/python/cpython/commit/146351860a34b3cde387930a360e57391e7b99f3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +7032

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 5dbb48aaac0ff74648b355ebdde222856004b1ef by Victor Stinner in 
branch '3.6':
[3.6] bpo-31234: Add test.support.wait_threads_exit() (GH-3578) (GH-7315)
https://github.com/python/cpython/commit/5dbb48aaac0ff74648b355ebdde222856004b1ef


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +6945

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor  added the comment:

It seems like all attached PR are now merged. I didn't see any random "dangling 
thread" warning recently in the master branch, so I close this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 2c1c2ca2548f943d6323859f17612aa5a4a19165 by Victor Stinner in 
branch '3.6':
[3.6] bpo-31234: Join threads in tests (#3589)
https://github.com/python/cpython/commit/2c1c2ca2548f943d6323859f17612aa5a4a19165


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 11f0807a407551d498bb6bd8cc932636f75f1cd7 by Victor Stinner in 
branch 'master':
bpo-31234: test_multiprocessing: wait 30 seconds (#3599)
https://github.com/python/cpython/commit/11f0807a407551d498bb6bd8cc932636f75f1cd7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3591

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

Oh, one change of the commit b9b69003d91c6ea94b890ce24ed25686d30f1428 
introduced a regression x86 Gentoo Refleaks 3.x. It seems like 5 seconds is not 
enough on this slow buildbot.

http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%203.x/builds/93/steps/test/logs/stdio

2:28:30 load avg: 6.98 [263/405/1] test_multiprocessing_spawn failed -- 
running: test_zipfile (797 sec)
beginning 6 repetitions
123456
.Process Process-555:1:1:
Traceback (most recent call last):
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/multiprocessing/process.py",
 line 297, in _bootstrap
self.run()
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/multiprocessing/process.py",
 line 99, in run
self._target(*self._args, **self._kwargs)
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/_test_multiprocessing.py",
 line 4050, in child
join_process(p, timeout=5)
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/_test_multiprocessing.py",
 line 79, in join_process
support.join_thread(process, timeout)
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/support/__init__.py",
 line 2117, in join_thread
raise AssertionError(msg)
AssertionError: failed to join the thread in 5.0 seconds

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset da3e5cf961f9bcc4bb376386cfe7a2865325086c by Victor Stinner in 
branch 'master':
bpo-31234: Join timers in test_threading (#3598)
https://github.com/python/cpython/commit/da3e5cf961f9bcc4bb376386cfe7a2865325086c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3590

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

Buildbots want my death :-( They never stop failing. Yet another random warning 
considered as an error:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.x/builds/896/steps/test/logs/stdio

Run tests in parallel using 2 child processes
(...)
0:07:33 load avg: 1.17 [285/405/1] test_threading failed (env changed)
(...)
test_init_immutable_default_args (test.test_threading.TimerTests) ... Warning 
-- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Dangling thread: 
Dangling thread: <_MainThread(MainThread, started 34368581632)>
ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3580

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset b9b69003d91c6ea94b890ce24ed25686d30f1428 by Victor Stinner in 
branch 'master':
bpo-31234: Add support.join_thread() helper (#3587)
https://github.com/python/cpython/commit/b9b69003d91c6ea94b890ce24ed25686d30f1428


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3578

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 167cbde50a88ec2a7d26b2cb9891d5e32bdfbfb5 by Victor Stinner in 
branch 'master':
bpo-31234: Join threads in test_queue (#3586)
https://github.com/python/cpython/commit/167cbde50a88ec2a7d26b2cb9891d5e32bdfbfb5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3577

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset b8c7be2c523b012e57915182543d06657161057f by Victor Stinner in 
branch 'master':
bpo-31234: Join threads in test_threading (#3579)
https://github.com/python/cpython/commit/b8c7be2c523b012e57915182543d06657161057f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset ff40ecda73178dfcad24e26240d684356ef20793 by Victor Stinner in 
branch 'master':
bpo-31234: Add test.support.wait_threads_exit() (#3578)
https://github.com/python/cpython/commit/ff40ecda73178dfcad24e26240d684356ef20793


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3569

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3568

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 8dcf22f442320e4c1a5408e67b4c9002ad105f17 by Victor Stinner in 
branch 'master':
bpo-31234: Join threads in test_hashlib (#3573)
https://github.com/python/cpython/commit/8dcf22f442320e4c1a5408e67b4c9002ad105f17


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 18e95b4176256f100429a806d0455406df98f984 by Victor Stinner in 
branch 'master':
bpo-31234: Join threads in tests (#3572)
https://github.com/python/cpython/commit/18e95b4176256f100429a806d0455406df98f984


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3564

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3562

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

Oh, test_concurrent_futures.test_exception_with_success() failed on Travis CI 
:-(

https://ci.appveyor.com/project/python/cpython/build/3.7.0a0.6457

test_exception_with_success (test.test_concurrent_futures.FutureTests) ... 
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 
2)
Dangling thread: 
Dangling thread: <_MainThread(MainThread, started 3656)>
ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.x/builds/881/steps/test/logs/stdio

0:08:05 load avg: 1.58 [288/405/1] test_threading failed (env changed) -- 
running: test_multiprocessing_spawn (83 sec)
(...)
test_dummy_thread_after_fork (test.test_threading.ThreadTests) ... ok
test_enumerate_after_join (test.test_threading.ThreadTests) ... ok
test_finalize_runnning_thread (test.test_threading.ThreadTests) ... ok
test_finalize_with_trace (test.test_threading.ThreadTests) ... ok
test_foreign_thread (test.test_threading.ThreadTests) ...

Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 
1)
Dangling thread: <_MainThread(MainThread, started 34368585728)>

ok
test_frame_tstate_tracing (test.test_threading.ThreadTests) ... ok
test_ident_of_no_threading_threads (test.test_threading.ThreadTests) ... ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

3 more warnings in test_threading on AMD64 FreeBSD 10.x Shared 3.x:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/886/steps/test/logs/stdio

0:03:45 load avg: 4.05 [246/405/1] test_thread failed (env changed)
(...)
test_nt_and_posix_stack_size (test.test_thread.ThreadRunningTests) ... (...)
task 4 done
task 10 done
all tasks done
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 
1)
Dangling thread: <_MainThread(MainThread, started 34393318400)>
ok
(...)
test_starting_threads (test.test_thread.ThreadRunningTests) ...
(...)
task 9 will run for 55us
task 9 done
all tasks done
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 
1)
Dangling thread: <_MainThread(MainThread, started 34393318400)>
ok


http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/884/steps/test/logs/stdio

0:05:44 load avg: 3.00 [249/405/1] test_thread failed (env changed) -- running: 
test_concurrent_futures (31 sec), test_multiprocessing_fork (60 sec)
test_barrier (test.test_thread.BarrierTest) ...
(...)
task 5 leaving barrier
task 3 leaving barrier
tasks done
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 
1)
Dangling thread: <_MainThread(MainThread, started 34393318400)>
ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_threading.test_foreign_thread() failed:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Debug%203.x/builds/879/steps/test/logs/stdio

0:08:53 load avg: 1.84 [286/405/1] test_threading failed (env changed) -- 
running: test_multiprocessing_spawn (51 sec)
(...)
test_dummy_thread_after_fork (test.test_threading.ThreadTests) ... ok
test_enumerate_after_join (test.test_threading.ThreadTests) ... ok
test_finalize_runnning_thread (test.test_threading.ThreadTests) ... ok
test_finalize_with_trace (test.test_threading.ThreadTests) ... ok
test_foreign_thread (test.test_threading.ThreadTests) ... Warning -- 
threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 1)
Dangling thread: <_MainThread(MainThread, started 34369060864)>
ok
test_frame_tstate_tracing (test.test_threading.ThreadTests) ... ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 096ae3373abac2c8b3a26a3fe33cc8bd4cbccd4e by Victor Stinner in 
branch 'master':
bpo-31234: Try to fix lock_tests warning (#3557)
https://github.com/python/cpython/commit/096ae3373abac2c8b3a26a3fe33cc8bd4cbccd4e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3549

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset ef323e8d82b07d4e7e4303c360dc32d3de0b3147 by Victor Stinner in 
branch '3.6':
[3.6] bpo-31234: Fix dangling thread in test_ftp/poplib (#3554)
https://github.com/python/cpython/commit/ef323e8d82b07d4e7e4303c360dc32d3de0b3147


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset d99e85b9f6422dd5e4f2eb1539368fc4003d4c8b by Victor Stinner (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31234, socket.create_connection(): Fix ref cycle (GH-3546) (#3552)
https://github.com/python/cpython/commit/d99e85b9f6422dd5e4f2eb1539368fc4003d4c8b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

Source_ModuleLockAsRLockTests.test_different_thread() of 
test.test_importlib.test_locks failed:

http://buildbot.python.org/all/builders/x86-64%20El%20Capitan%203.x/builds/758/steps/test/logs/stdio

test_different_thread 
(test.test_importlib.test_locks.Source_ModuleLockAsRLockTests) ... Warning -- 
threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 1)
Dangling thread: <_MainThread(MainThread, started 140735235059712)>
ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

Hum, test_barrier of test_thread failed:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/880/steps/test/logs/stdio

0:02:09 load avg: 2.50 [106/405/1] test_thread failed (env changed) -- running: 
test_multiprocessing_spawn (63 sec), test_multiprocessing_forkserver (54 sec)

test_barrier (test.test_thread.BarrierTest) ...
(...)
task 8 leaving barrier
task 2 leaving barrier
task 9 leaving barrier
tasks done
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 
1)
Dangling thread: <_MainThread(MainThread, started 34393318400)>
ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3546

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3545

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset ace1ecc00b35a8b1dc6e352d547dde07913017bb by Victor Stinner in 
branch 'master':
bpo-31234: threading_cleanup() now warns immediately (#3138)
https://github.com/python/cpython/commit/ace1ecc00b35a8b1dc6e352d547dde07913017bb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset acb9fa79fa6453c2bbe3ccfc9cad2837feb90093 by Victor Stinner in 
branch 'master':
bpo-31234, socket.create_connection(): Fix ref cycle (#3546)
https://github.com/python/cpython/commit/acb9fa79fa6453c2bbe3ccfc9cad2837feb90093


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3539

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_ssl:

test_recv_zero (test.test_ssl.ThreadedTests) ...  server:  new connection from 
('127.0.0.1', 54502)
 server: connection cipher is now ('ECDHE-RSA-AES256-SHA', 'TLSv1/SSLv3', 256)
 server: selected protocol is now None
Warning -- threading_cleanup() failed to cleanup 0 threads (count: 0, dangling: 
2)
Dangling thread: <_MainThread(MainThread, started 4757722688)>
Dangling thread: 
ok

test_socketserver (test.test_ssl.ThreadedTests)
(...)
stopping HTTPS server
joining HTTPS thread
Warning -- threading_cleanup() failed to cleanup 0 threads (count: 0, dangling: 
2)
Dangling thread: 
Dangling thread: <_MainThread(MainThread, started 4757722688)>
ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset b157ce1e58b03988ce4340a55d0b856125833cc5 by Victor Stinner in 
branch 'master':
bpo-31234: Fix dangling thread in test_ftplib (#3544)
https://github.com/python/cpython/commit/b157ce1e58b03988ce4340a55d0b856125833cc5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3538

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset d403a29c0055de6b03ed5ae7a5c564e1c95a5950 by Victor Stinner in 
branch 'master':
bpo-31234: Fix dangling thread in test_ftp/poplib (#3540)
https://github.com/python/cpython/commit/d403a29c0055de6b03ed5ae7a5c564e1c95a5950


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3535

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 89bfc9b0d9033f7c9f086c7281a31a489fe1136f by Victor Stinner (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31234: test_threaded_import: fix test_side_effect_import() (GH-3189) 
(#3537)
https://github.com/python/cpython/commit/89bfc9b0d9033f7c9f086c7281a31a489fe1136f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 6c25b73194714e78975eddea3799f06f3de74647 by Victor Stinner (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31234: test_httpservers joins the server thread (GH-3188) (#3536)
https://github.com/python/cpython/commit/6c25b73194714e78975eddea3799f06f3de74647


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 42f7e0d8b0ca940a809a786f25d967dcce4d71b6 by Victor Stinner in 
branch '2.7':
bpo-31234: fork_wait tests now join threads (#3139) (#3535)
https://github.com/python/cpython/commit/42f7e0d8b0ca940a809a786f25d967dcce4d71b6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

I rebased PR 3138: 3 tests failed on Travis CI.

test_ssl:

Warning -- threading_cleanup() failed to cleanup 0 threads (count: 0, dangling: 
3)
Dangling thread: 
Dangling thread: 
Dangling thread: <_MainThread(MainThread, started 47903383548928)>

test_poplib:

Warning -- threading_cleanup() failed to cleanup 0 threads (count: 0, dangling: 
3)
Dangling thread: 
Dangling thread: <_MainThread(MainThread, started 47566631539712)>
Dangling thread: 
/home/travis/build/python/cpython/Lib/test/support/__init__.py:1511: 
ResourceWarning: unclosed 
  gc.collect()
/home/travis/build/python/cpython/Lib/test/support/__init__.py:1511: 
ResourceWarning: unclosed 
  gc.collect()
/home/travis/build/python/cpython/Lib/test/support/__init__.py:1511: 
ResourceWarning: unclosed 
  gc.collect()

test_ftplib:

Warning -- threading_cleanup() failed to cleanup 0 threads (count: 0, dangling: 
4)
Dangling thread: 
Dangling thread: 
Dangling thread: 
Dangling thread: <_MainThread(MainThread, started 47769182004224)>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3532

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3531

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3530

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

Remaining issue: socketserver. bpo-31233: socketserver.ThreadingMixIn leaks 
running threads after server_close()

See also bpo-31151: socketserver.ForkingMixIn.server_close() leaks zombie 
processes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset bcf042ff98b6261b7780c1e40fa1681ef30502f9 by Victor Stinner (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31234: Enhance test_thread.test_forkinthread() (GH-3516) (#3519)
https://github.com/python/cpython/commit/bcf042ff98b6261b7780c1e40fa1681ef30502f9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset a15d155aadfad232158f530278505cdc6f326f93 by Victor Stinner in 
branch 'master':
bpo-31234: Enhance test_thread.test_forkinthread() (#3516)
https://github.com/python/cpython/commit/a15d155aadfad232158f530278505cdc6f326f93


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3515

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
keywords: +patch
pull_requests: +3510
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

Remaining issues:

* test_asyncio: https://github.com/python/cpython/pull/3264 of bpo-31250

* test_thread: test_forkinthread() spawns a thread using 
thread.start_new_thread() without waiting until the thread completes

* test_concurrent_futures: warnings raised when running "./python -u -m test 
-j0 -rW -u all --fail-env-changed", but not when running only 
test_concurrent_futures. It looks like a race condition.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_ssl still emits a warning: see bpo-31323.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 41bbd82b6b6a887e893974fa5cdaae7782ae6cac by Victor Stinner in 
branch 'master':
bpo-31234: test_threaded_import: fix test_side_effect_import() (#3189)
https://github.com/python/cpython/commit/41bbd82b6b6a887e893974fa5cdaae7782ae6cac


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 830d7d2936434ace113822294acce82f62cde41b by Victor Stinner in 
branch 'master':
bpo-31234: test_httpservers joins the server thread (#3188)
https://github.com/python/cpython/commit/830d7d2936434ace113822294acce82f62cde41b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 5f20539ee5c6e3f1da23e8fc31ba519a3d078c79 by Victor Stinner in 
branch '3.6':
bpo-31234: fork_wait tests now join threads (#3139) (#3187)
https://github.com/python/cpython/commit/5f20539ee5c6e3f1da23e8fc31ba519a3d078c79


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3228

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3227

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3226

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_asyncio: bpo-31250, "test_asyncio leaks dangling threads".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_concurrent_futures: bpo-31249, test_concurrent_futures leaks dangling 
threads.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_xmlrpc: bpo-31247, "test_xmlrpc leaks dangling threads".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset b50e7683acac36ff16e6c6c2c32d9a15e46b5174 by Victor Stinner in 
branch '3.6':
bpo-31234: test_threading: fix ref cycle (#3150) (#3152)
https://github.com/python/cpython/commit/b50e7683acac36ff16e6c6c2c32d9a15e46b5174


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3186

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset 3d284c081fc3042036adfe1bf2ce92c34d743b0b by Victor Stinner in 
branch 'master':
bpo-31234: test_threading: fix ref cycle (#3150)
https://github.com/python/cpython/commit/3d284c081fc3042036adfe1bf2ce92c34d743b0b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_logging: see bpo-30830.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_pydoc: see bpo-31238.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_threading: https://github.com/python/cpython/pull/3150

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3184

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:


New changeset c99d41f9c0304fcf06550515c3db55f93a629e9e by Victor Stinner in 
branch 'master':
bpo-31234: fork_wait tests now join threads (#3139)
https://github.com/python/cpython/commit/c99d41f9c0304fcf06550515c3db55f93a629e9e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

STINNER Victor added the comment:

test_fork1, test_wait3: https://github.com/python/cpython/pull/3139

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3173

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3172

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31234] Make support.threading_cleanup() stricter

[STINNER Victor]

New submission from STINNER Victor:

Currently, support.threading_cleanup() waits 1 second before emitting a warning 
about threads running in the background. I propose to emit immediately the 
warning to be able to catch bugs quicker, bugs like bpo-31233 or bpo-30830.

The problem is that currently, 12 test files still leak threads:
---
12 tests altered the execution environment:
test_asyncio test_concurrent_futures test_fork1 test_httpservers
test_logging test_pydoc test_ssl test_thread test_threaded_import
test_threading test_wait3 test_xmlrpc
---

Since threading_cleanup() warnings now mark tests as failed, we should first 
fix these tests before being able to make support.threading_cleanup() stricter.

--
components: Tests
messages: 300519
nosy: haypo
priority: normal
severity: normal
status: open
title: Make support.threading_cleanup() stricter
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com