[issue31500] IDLE: Tiny font on HiDPI display

Tal Einat added the comment: Just tested on a 13" Retina MacBook Pro (2560x1600), everything looks fine. -- nosy: +taleinat ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: New changeset f125d788ff71095390a9e190da6722eb00166cd4 by Terry Jan Reedy in branch '2.7': bpo-31500: Default fonts now are scaled on HiDPI displays. (#10015) https://github.com/python/cpython/commit/f125d788ff71095390a9e190da6722eb00166cd4 --

[issue31500] IDLE: Tiny font on HiDPI display

Change by Terry J. Reedy : -- pull_requests: +9352 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: New changeset 18c44cc0c13eed792e286ddc1d331951e723aeb9 by Terry Jan Reedy (Cheryl Sabella) in branch '2.7': [2.7] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) (GH-6585)

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: My inclination, then, is to close this issue and PR until there is a demonstrated need for change and a test machine to verify the fix for 2.7 and 8.5.19. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: Seems IDLE now works on my HiDPI screen without the patch. It looks the same as IDLE in 3.x with the patch. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: Does IDLE now work on your HiDPI screen without the patch? or does it not work even with the patch? I just got a 2.7 worktree working with Python built. 2.7.15+ comes with 8.5.19 instead of 8.5.15. IDLE runs as I expect and windows look

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: Something was changed on my computer (I upgraded the OS twice since creating this issue), and now I don't see any difference between patched and unpatched 2.7. Terry, could you please test whether there are any visible effects

[issue31500] IDLE: Tiny font on HiDPI display

Change by Cheryl Sabella : -- pull_requests: +6284 stage: needs patch -> patch review ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: You promised to make backports to 2.7 when did the mass files renaming. The simple cherry-picking doesn't work, and I even don't know what files in 2.7 should be changed. -- ___

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: I guess I was not clear enough that I will test on Windows after someone else does a backport that works on Linux. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: I take it you want this reopened. I have not touched IDLE 2.7 for over a year, but since a) there have been no complaints about the patch in released 3.6.3/4, b) we recommend the same tk 8.5.18 for both 2.7 and 3.6, and c) this is a

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: What about 2.7? -- ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: I assume that the 2nd patch, by Serhiy, fixed the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: New changeset 0c4997f1919d8583353b12537a63dcbe7b9d280f by Terry Jan Reedy in branch '3.6': [3.6] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) (#3686) https://github.com/python/cpython/commit/0c4997f1919d8583353b12537a63dcbe7b9d280f

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Terry J. Reedy : -- pull_requests: +3675 ___ Python tracker ___ ___

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: New changeset a96c96f5dab68d4e611af4b8caefd7268533fd9a by Serhiy Storchaka in branch 'master': bpo-31500: IDLE: Scale default fonts on HiDPI displays. (#3639) https://github.com/python/cpython/commit/a96c96f5dab68d4e611af4b8caefd7268533fd9a --

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: The limit 1.4 is not arbitrary. This is a minimal scale for which fonts from 10 to 14 pixels are not decreased when converted to points (with multiplier 0.75 and one rounding). round(14 * 0.75) = round(10.5) = 10; 10 * 1.4 = 14. --

[issue31500] IDLE: Tiny font on HiDPI display

Cheryl Sabella added the comment: The scaling factor of 1.4 worked and the menu and configdialog looked normal. font['size'] = 9 also worked as did font['size'] = 10. font['size'] = 12 is when it's too big. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: My screen is 23.5 x 13.25, making it 109 DPI. I asked Cheryl to try 9 first because it is 3/4 of 12. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: If just negate the size the menu and the dialog fonts look like on a display with 72 DPI. But currently monitors rarely have such DPI. Normal displays have about 100 DPI (scaling factor about 1.33). If we want to keep font sizes on such displays we should

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: I mean ' if scaling >= 1.2:' in run.fix_scaling. It would also be interesting to instead replace the last line, "font['size'] = -size" with "font['size'] = 9" (or 8 or 10) and see how close the dialog is to what is was before. --

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: It appears that the cutoff of 1.2 in the patch is too low. Try raising it to 1.4 and you should see the dialog normal. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Cheryl Sabella added the comment: configdialog looks better now, but the fonts are still huge. The configdialog is almost bigger than the shell when it opens. -- Added file: https://bugs.python.org/file47155/configkey_2.png ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Cheryl Sabella added the comment: >>> import tkinter as tk >>> root = tk.Tk() >>> print(float(root.tk.call('tk', 'scaling'))) 1. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: New changeset 97be14996b247b853ead77fb255d7029e3cf3dc9 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31500: Removed fixed size of IDLE config dialog. (GH-3664) (#3665)

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Roundup Robot : -- pull_requests: +3654 ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: New changeset d6e2f26f3f7c62a4ddbf668027d3ba27cb0e1eca by Terry Jan Reedy in branch 'master': bpo-31500: Removed fixed size of IDLE config dialog. (#3664) https://github.com/python/cpython/commit/d6e2f26f3f7c62a4ddbf668027d3ba27cb0e1eca --

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Terry J. Reedy : -- pull_requests: +3653 ___ Python tracker ___ ___

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: Cheryl, what do you get with import tkinter as tk root = tk.Tk() print(float(root.tk.call('tk', 'scaling'))) If it is less than 1.2, then Serhiy's revised patch should leave config dialog as it should be. -- ___

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: The Keys and General tabs are messed up even more on my computer. Some sections are just not visible. This is because The dialog window uses hardcoded size in pixels, it is too small for all content. After removing the hardcoded size all looks good.

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: Thank you Cheryl. That is enough to reject the patch is it is now. The negative sizes are pixels. I think it might be better to multiply them by a systems specific factor, but only when needed. One might wish that the scaling should be handled

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Cheryl Sabella : Added file: https://bugs.python.org/file47149/configdialogkeys_new.png ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Cheryl Sabella : Removed file: https://bugs.python.org/file47147/configdialog_new.png ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Cheryl Sabella : Added file: https://bugs.python.org/file47148/configdialogkeys_old.png ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

Cheryl Sabella added the comment: Attached screen prints of configdialog. It's messed up. -- Added file: https://bugs.python.org/file47147/configdialog_new.png ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Cheryl Sabella added the comment: Tests run on Ubuntu. The menubar is bigger now though, so it's default is different than before. Maybe that was the only way to fix it, but it's now about twice as big as the shell font. -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: The TkFixedFont initially used in Shell and editor has its size set to 10 if initially negative. Users can only replace this with a real font, not another of tk's abstract fonts. On windows, the sizes of the nearly 20 fonts touched by the patch range from 8

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: PR 3639 adapts the receipt from [1]. I'm not sure that it doesn't add regressions on low-DPI displays. [1] https://wiki.tcl.tk/8488 -- ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Serhiy Storchaka : -- keywords: +patch pull_requests: +3633 stage: -> patch review ___ Python tracker ___

[issue31500] IDLE: Tiny font on HiDPI display

New submission from Serhiy Storchaka: My new laptop has a HiDPI display (3840x2160). IDLE (as well as other Tk applications) looks ugly on it. The font of menu and dialogs is tiny. The font used in editor and shell looks normal size. I use Linux with X Window. It seems to me this issue