[issue31500] IDLE: Tiny font on HiDPI display

[Tal Einat]

Tal Einat  added the comment:

Just tested on a 13" Retina MacBook Pro (2560x1600), everything looks fine.

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset f125d788ff71095390a9e190da6722eb00166cd4 by Terry Jan Reedy in 
branch '2.7':
bpo-31500: Default fonts now are scaled on HiDPI displays. (#10015)
https://github.com/python/cpython/commit/f125d788ff71095390a9e190da6722eb00166cd4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +9352

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 18c44cc0c13eed792e286ddc1d331951e723aeb9 by Terry Jan Reedy 
(Cheryl Sabella) in branch '2.7':
[2.7] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) 
(GH-6585)
https://github.com/python/cpython/commit/18c44cc0c13eed792e286ddc1d331951e723aeb9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy  added the comment:

My inclination, then, is to close this issue and PR until there is a 
demonstrated need for change and a test machine to verify the fix for 2.7 and 
8.5.19.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Seems IDLE now works on my HiDPI screen without the patch. It looks the same as 
IDLE in 3.x with the patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Does IDLE now work on your HiDPI screen without the patch? or does it not work 
even with the patch?  

I just got a 2.7 worktree working with Python built.  2.7.15+ comes with 8.5.19 
instead of 8.5.15.  IDLE runs as I expect and windows look normal, as with 3.x, 
both before and after the patch.  

If calling fix_scaling ever causes anyone a problem on some particular 
combination of OS, Python, and Tk versions, they could neutralize it by adding 
the following after the current definition.

def fix_scaling: pass

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Something was changed on my computer (I upgraded the OS twice since creating 
this issue), and now I don't see any difference between patched and unpatched 
2.7. Terry, could you please test whether there are any visible effects on 
Windows?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests: +6284
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

You promised to make backports to 2.7 when did the mass files renaming. The 
simple cherry-picking doesn't work, and I even don't know what files in 2.7 
should be changed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I guess I was not clear enough that I will test on Windows after someone else 
does a backport that works on Linux.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I take it you want this reopened.  I have not touched IDLE 2.7 for over a year, 
but since a) there have been no complaints about the patch in released 3.6.3/4, 
b) we recommend the same tk 8.5.18 for both 2.7 and 3.6, and c) this is a 
crippling regression upon equipment upgrade, I will review and manually test on 
Windows a combined backport of both PRs first tested on a Linux or Mac system.  
It should be tested on a HiDPI system before a merge.

--
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open
versions:  -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

What about 2.7?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I assume that the 2nd patch, by Serhiy, fixed the issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 0c4997f1919d8583353b12537a63dcbe7b9d280f by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) (#3686)
https://github.com/python/cpython/commit/0c4997f1919d8583353b12537a63dcbe7b9d280f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +3675

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset a96c96f5dab68d4e611af4b8caefd7268533fd9a by Serhiy Storchaka in 
branch 'master':
bpo-31500: IDLE: Scale default fonts on HiDPI displays. (#3639)
https://github.com/python/cpython/commit/a96c96f5dab68d4e611af4b8caefd7268533fd9a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The limit 1.4 is not arbitrary. This is a minimal scale for which fonts from 10 
to 14 pixels are not decreased when converted to points (with multiplier 0.75 
and one rounding). round(14 * 0.75) = round(10.5) = 10; 10 * 1.4 = 14.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Cheryl Sabella added the comment:

The scaling factor of 1.4 worked and the menu and configdialog looked normal.

font['size'] = 9 also worked as did font['size'] = 10.  font['size'] = 12 is 
when it's too big.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:

My screen is 23.5 x 13.25, making it 109 DPI.  I asked Cheryl to try 9 first 
because it is 3/4 of 12.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

If just negate the size the menu and the dialog fonts look like on a display 
with 72 DPI. But currently monitors rarely have such DPI. Normal displays have 
about 100 DPI (scaling factor about 1.33). If we want to keep font sizes on 
such displays we should multiply sizes by 0.75 for converting from pixels to 
points.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:

I mean '  if scaling >= 1.2:' in run.fix_scaling.  It would also be interesting 
to instead replace the last line,  "font['size'] = -size" with "font['size'] = 
9" (or 8 or 10) and see how close the dialog is to what is was before.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:

It appears that the cutoff of 1.2 in the patch is too low.  Try raising it to 
1.4 and you should see the dialog normal.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Cheryl Sabella added the comment:

configdialog looks better now, but the fonts are still huge.  The configdialog 
is almost bigger than the shell when it opens.

--
Added file: https://bugs.python.org/file47155/configkey_2.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Cheryl Sabella added the comment:

>>> import tkinter as tk
>>> root = tk.Tk()
>>> print(float(root.tk.call('tk', 'scaling')))
1.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 97be14996b247b853ead77fb255d7029e3cf3dc9 by Terry Jan Reedy (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31500: Removed fixed size of IDLE config dialog. (GH-3664) (#3665)
https://github.com/python/cpython/commit/97be14996b247b853ead77fb255d7029e3cf3dc9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3654

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset d6e2f26f3f7c62a4ddbf668027d3ba27cb0e1eca by Terry Jan Reedy in 
branch 'master':
bpo-31500: Removed fixed size of IDLE config dialog. (#3664)
https://github.com/python/cpython/commit/d6e2f26f3f7c62a4ddbf668027d3ba27cb0e1eca


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +3653

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:

Cheryl, what do you get with

import tkinter as tk
root = tk.Tk()
print(float(root.tk.call('tk', 'scaling')))

If it is less than 1.2, then Serhiy's revised patch should leave config dialog 
as it should be.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The Keys and General tabs are messed up even more on my computer. Some sections 
are just not visible. This is because The dialog window uses hardcoded size in 
pixels, it is too small for all content. After removing the hardcoded size all 
looks good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:

Thank you Cheryl.  That is enough to reject the patch is it is now.

The negative sizes are pixels.  I think it might be better to multiply them by 
a systems specific factor, but only when needed.

One might wish that the scaling should be handled automatically, in tkinter if 
not in tk itself.  But it was mentioned in one of the links that displays do 
not always report their dpi correctly.

One possibility is a tkinter calibration app that displays a 500 or 1000 pixel 
line (user selects) and asks the user to input the physical length (centimeters 
or inches).  (Some games do something similar with brightness.)

To check whether a tkinter scaling app could be used, I sized Serhiy's image so 
that the sample font in the Settings Font tab matched the sample font in a real 
box.  The system font around it is tiny but readable, especially with a 
magnifier.

This is a tkinter issue, not only an IDLE issue, but IDLE is a good test app, 
with realistically complex dialogs. Lacking a Python-wide fix, something could 
be added to the Font tab -- for instance a dpi multiplier that defaults to one. 
 It would only be used if not 1.0.

I reread config.IdleConf.GetFont.  Rather than manipulate one of tk's default 
fonts ('TkFixedFont'), it creates a normal font sized in points.  It uses 
'TkFixedFont' as a handy key for finding a system-specific sure-to-exist fixed 
pitch font: "actualFont = Font.actual(f)", where f is a TkFixedFont instance.  
Thus it does not affect the dialogs.

It would be helpful to know if HiDPI screens on Windows have a problem.

#31496 is about test_configdialog failing on the same HiDPI screen.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Changes by Cheryl Sabella :


Added file: https://bugs.python.org/file47149/configdialogkeys_new.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Changes by Cheryl Sabella :


Removed file: https://bugs.python.org/file47147/configdialog_new.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Changes by Cheryl Sabella :


Added file: https://bugs.python.org/file47148/configdialogkeys_old.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Cheryl Sabella added the comment:

Attached screen prints of configdialog.  It's messed up.

--
Added file: https://bugs.python.org/file47147/configdialog_new.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Cheryl Sabella]

Cheryl Sabella added the comment:

Tests run on Ubuntu.  The menubar is bigger now though, so it's default is
different than before.  Maybe that was the only way to fix it, but it's now
about twice as big as the shell font.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Terry J. Reedy]

Terry J. Reedy added the comment:

The TkFixedFont initially used in Shell and editor has its size set to 10 if 
initially negative. Users can only replace this with a real font, not another 
of tk's abstract fonts.

On windows, the sizes of the nearly 20 fonts touched by the patch range from 8 
to 12.  So no possible regression there.  If the sizes on Linux were in the 
range -8 to -12, then the effect is to replace the size with numbers around 10 
instead of exactly 10 (as IDLE currently does).  But from what you said on the 
patch, the negative numbers are not exactly the negative of their real size, 
but are tuned for positioning.

Cheryy, Louie, and Ned: the patch needs to be test on multiple *nix machines, 
especially on OSX, to make sure it does not mess up on standard monitors.  A 
quick 'git pr 3639' and 'python -m test.test_idle' would be helpful.

--
nosy: +csabella, louielu, ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

PR 3639 adapts the receipt from [1]. I'm not sure that it doesn't add 
regressions on low-DPI displays.

[1] https://wiki.tcl.tk/8488

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +3633
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

My new laptop has a HiDPI display (3840x2160). IDLE (as well as other Tk 
applications) looks ugly on it. The font of menu and dialogs is tiny. The font 
used in editor and shell looks normal size. I use Linux with X Window.

It seems to me this issue doesn't have solution. Related links:

https://wiki.tcl.tk/41949
https://core.tcl.tk/tk/tktview/0917069c05e9c354a27c8105a7a22264090b9274
https://stackoverflow.com/questions/34132203/scaling-of-tkinter-gui-in-4k-38402160-resolution

--
assignee: terry.reedy
components: IDLE
files: Screenshot_20170917_213616.png
messages: 302381
nosy: serhiy.storchaka, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Tiny font on HiDPI display
type: behavior
versions: Python 2.7, Python 3.6, Python 3.7
Added file: https://bugs.python.org/file47141/Screenshot_20170917_213616.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com