[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Change by Benjamin Peterson : -- pull_requests: +22560 pull_request: https://github.com/python/cpython/pull/9178 ___ Python tracker ___

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Benjamin Peterson added the comment: New changeset 253279c616d4f34287c5749df15e20eb2eb988d6 by Benjamin Peterson in branch '2.7': [2.7] closes bpo-31608: Fix a crash in methods of a subclass of _collections.deque with a bad __new__(). (GH-9179)

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Benjamin Peterson added the comment: New changeset ccbbdd0a1e00ecad6f0005438dd6ff6d84fd9ceb by Benjamin Peterson in branch '3.6': [3.6] closes bpo-31608: Fix a crash in methods of a subclass of _collections.deque with a bad __new__(). (GH-9178)

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

miss-islington added the comment: New changeset 536e45accf8f05355dd943a6966b9968cdb15f5a by Miss Islington (bot) in branch '3.7': closes bpo-31608: Fix a crash in methods of a subclass of _collections.deque with a bad __new__(). (GH-3788)

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Change by Benjamin Peterson : -- pull_requests: +8618 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Change by miss-islington : -- pull_requests: +8616 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Benjamin Peterson added the comment: New changeset 24bd50bdcc97d65130c07d6cd26085fd06c3e972 by Benjamin Peterson (Oren Milman) in branch 'master': closes bpo-31608: Fix a crash in methods of a subclass of _collections.deque with a bad __new__(). (GH-3788)

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Serhiy Storchaka added the comment: I meant that if make deque.copy(), deque.__add__() and deque.__mul__() returning an exact deque for subclasses, this would make the deque class more consistent with other collections and solve this issue. This could even make

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Serhiy Storchaka added the comment: All other sequence objects return an instance of the base class rather than a subclass. list, tuple, str, bytes, bytearray, array. Only deque tries to create an instance of a subclass. -- assignee: -> rhettinger nosy:

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

Change by Oren Milman : -- keywords: +patch pull_requests: +3774 stage: -> patch review ___ Python tracker ___

[issue31608] crash in methods of a subclass of _collections.deque with a bad __new__()

New submission from Oren Milman : The following code causes the interpreter to crash: import _collections class BadDeque(_collections.deque): def __new__(cls, *args): if len(args): return 42 return _collections.deque.__new__(cls) BadDeque() *