[issue31956] Add start and stop parameters to the array.index()

Change by Dong-hee Na : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.7 ___ Python tracker ___

[issue31956] Add start and stop parameters to the array.index()

Dong-hee Na added the comment: New changeset afd12650580725ac598b2845384771c14c4f952e by Zackery Spytz in branch 'master': bpo-31956: Add start and stop parameters to array.index() (GH-25059) https://github.com/python/cpython/commit/afd12650580725ac598b2845384771c14c4f952e --

[issue31956] Add start and stop parameters to the array.index()

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31956] Add start and stop parameters to the array.index()

Change by Zackery Spytz : -- nosy: +ZackerySpytz nosy_count: 8.0 -> 9.0 pull_requests: +23807 pull_request: https://github.com/python/cpython/pull/25059 ___ Python tracker ___

[issue31956] Add start and stop parameters to the array.index()

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31956] Add start and stop parameters to the array.index()

Change by Kamil Turek : -- nosy: +kamilturek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31956] Add start and stop parameters to the array.index()

Cheryl Sabella added the comment: I found this SO about reclaiming an orphaned pull request: https://stackoverflow.com/a/53383772 But you may still need to open a new PR for it. -- nosy: +cheryl.sabella ___ Python tracker

[issue31956] Add start and stop parameters to the array.index()

Anders Lorentsen added the comment: I have actually managed to lost my local branch of this fix, though I assume I can just start another one, manually copy over the changes, somehow mark this current PR as cancelled, aborted, or in my option the best: "replaced/superseeded by: [new PR]".

[issue31956] Add start and stop parameters to the array.index()

Anders Lorentsen added the comment: As far as I can recall, the patch is generally speaking good to go. A number of discussions arose on various details, however. In any event, I'll take a look at it during the next few days. -- ___ Python

[issue31956] Add start and stop parameters to the array.index()

Joannah Nanjekye added the comment: There is a pending PR here : https://github.com/python/cpython/pull/4435 by phaqui. @phaqui do you want to finish your PR ? -- nosy: +nanjekyejoannah ___ Python tracker

[issue31956] Add start and stop parameters to the array.index()

Ryan G. added the comment: This functionality is useful to me. Is this issue still alive? If not, how can I help? -- nosy: +Ryan G. ___ Python tracker ___

[issue31956] Add start and stop parameters to the array.index()

Change by Roundup Robot : -- keywords: +patch pull_requests: +4379 stage: -> patch review ___ Python tracker ___

[issue31956] Add start and stop parameters to the array.index()

Anders Lorentsen added the comment: Writing my tests, I originally looked at Lib/test/seq_tests.py. One test case uses indexes that are (+-)4*sys.maxsize. This does not fit in Py_ssize_t, and so these tests cause my array implementation to raise an overflow exception. A

[issue31956] Add start and stop parameters to the array.index()

STINNER Victor added the comment: Anders Lorentsen: Py_ssize_t is the correct type for an index in the C language. It's not technically possible to create an array object larger than PY_SSIZE_T_MAX items :-) Serhiy> Just take list.index as an example. I concur with

[issue31956] Add start and stop parameters to the array.index()

Serhiy Storchaka added the comment: Just take list.index as an example. -- components: +Extension Modules -Library (Lib) nosy: +serhiy.storchaka type: -> enhancement versions: +Python 3.7 -Python 3.8 ___ Python tracker

[issue31956] Add start and stop parameters to the array.index()

Anders Lorentsen added the comment: I decided to work on this, and I would like some review, as this would be my second contribution to cpython. Also, a general question: As I defined the start and end arguments Py_ssize_t, bigger indexes (more negative or more positive)

[issue31956] Add start and stop parameters to the array.index()

Николай Спахиев added the comment: I plan to work on a patch. -- ___ Python tracker ___

[issue31956] Add start and stop parameters to the array.index()

STINNER Victor added the comment: Николай Спахиев: Are you only asking for the feature, or are you interested to work on a concrete patch? -- nosy: +haypo ___ Python tracker

[issue31956] Add start and stop parameters to the array.index()

Raymond Hettinger added the comment: +1 -- nosy: +rhettinger ___ Python tracker ___

[issue31956] Add start and stop parameters to the array.index()

New submission from Николай Спахиев : Sequence protocol specifies 2 optional argument for index method: seq.index(value, [start, [stop]]) array.index(value) needs start and stop arguments too. -- components: Library (Lib) messages: 305629 nosy: Николай Спахиев