[issue32008] Example suggest to use a TLSv1 socket

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Hi,

I have merged the PR of Christian for master, 3.8 & 3.7

Thank you so much,

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset 1fc84b64f9f740f2dc089da1d061dfdd5b438d3c by Stéphane Wirtel in 
branch '3.8':
[3.8] bpo-32008: Prefer client or TLSv1_2 in examples (GH-5797) (GH-16027)
https://github.com/python/cpython/commit/1fc84b64f9f740f2dc089da1d061dfdd5b438d3c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset 07b4148f3932ed22f9cd8476f49bd0079d093590 by Stéphane Wirtel (Miss 
Islington (bot)) in branch '3.7':
bpo-32008: Prefer client or TLSv1_2 in examples (GH-5797) (GH-16026)
https://github.com/python/cpython/commit/07b4148f3932ed22f9cd8476f49bd0079d093590


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Stéphane Wirtel]

Change by Stéphane Wirtel :


--
pull_requests: +15650
pull_request: https://github.com/python/cpython/pull/16027

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset 894d0f7d5542ee04556ec1bee8c58506f7c916d4 by Stéphane Wirtel 
(Christian Heimes) in branch 'master':
bpo-32008: Prefer client or TLSv1_2 in examples (GH-5797)
https://github.com/python/cpython/commit/894d0f7d5542ee04556ec1bee8c58506f7c916d4


--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[miss-islington]

Change by miss-islington :


--
pull_requests: +15649
pull_request: https://github.com/python/cpython/pull/16026

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Cheryl Sabella]

Cheryl Sabella  added the comment:

@christian.heimes, this one looks ready to merge and close.  Please take a look 
when you get a chance.  Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +5576
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Christian Heimes]

Christian Heimes  added the comment:

Err, I meant PROTOCOL_TLS_CLIENT:

>>> import ssl
>>> context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
>>> context.check_hostname
True
>>> context.verify_mode


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Christian Heimes]

Christian Heimes  added the comment:

For 3.6 to 3.8 I'd prefer TLS_PROTOCOL_CLIENT. It also sets check_hostname and 
verify_mode to sane, safe values, too.

--
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open
versions: +Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset 6c7edba1665ea676328c6b50f92e8423c8f0d164 by Benjamin Peterson in 
branch '2.7':
[2.7] closes bpo-32008: don't use PROTOCOL_TLSv1 in example (GH-5789) (#5792)
https://github.com/python/cpython/commit/6c7edba1665ea676328c6b50f92e8423c8f0d164


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[miss-islington]

miss-islington  added the comment:


New changeset f8a794c04c8d375da279fc830770a5e6b4f363fb by Miss Islington (bot) 
in branch '3.6':
bpo-32008: don't use PROTOCOL_TLSv1 in example (GH-5789)
https://github.com/python/cpython/commit/f8a794c04c8d375da279fc830770a5e6b4f363fb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[miss-islington]

miss-islington  added the comment:


New changeset e5d38deb045d0907e6fcf82af8d2d8f0556a8591 by Miss Islington (bot) 
in branch '3.7':
bpo-32008: don't use PROTOCOL_TLSv1 in example (GH-5789)
https://github.com/python/cpython/commit/e5d38deb045d0907e6fcf82af8d2d8f0556a8591


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Benjamin Peterson]

Change by Benjamin Peterson :


--
pull_requests: +5573

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[miss-islington]

Change by miss-islington :


--
pull_requests: +5572

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset e9edee0b65650c4f9db90cefc2e9a8125bad762c by Benjamin Peterson in 
branch 'master':
bpo-32008: don't use PROTOCOL_TLSv1 in example (GH-5789)
https://github.com/python/cpython/commit/e9edee0b65650c4f9db90cefc2e9a8125bad762c


--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[miss-islington]

Change by miss-islington :


--
pull_requests: +5571

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Benjamin Peterson]

Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +5570
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Cheryl Sabella]

Cheryl Sabella  added the comment:

Christian,

Would you have any feedback on this?  Thanks!

--
nosy: +christian.heimes, csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32008] Example suggest to use a TLSv1 socket

[Kurt Roeckx]

New submission from Kurt Roeckx :

Here:
https://docs.python.org/3/library/ssl.html#ssl.SSLContext.check_hostname

And here:
https://docs.python.org/2/library/ssl.html#ssl.SSLContext.check_hostname

It uses ssl.PROTOCOL_TLSv1, which is a bad example. Please change it to 
PROTOCOL_SSLv23 or PROTOCOL_TLS.

(Those were the first 2 examples I could find via google on how to create an 
ssl connection using python.)

--
assignee: docs@python
components: Documentation
messages: 306093
nosy: docs@python, kroeckx
priority: normal
severity: normal
status: open
title: Example suggest to use a TLSv1 socket
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com