[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[miss-islington]

miss-islington  added the comment:


New changeset dd52d5c868fb1eb33bcf22e777317de0391bfaf6 by Miss Islington (bot) 
in branch '3.6':
bpo-32087: Doc: Make "deprecated-removed"  directive translatable (GH-4473)
https://github.com/python/cpython/commit/dd52d5c868fb1eb33bcf22e777317de0391bfaf6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[INADA Naoki]

Change by INADA Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[miss-islington]

miss-islington  added the comment:


New changeset c673a62d5f3c650130bf40f2161a2eac64419bce by Miss Islington (bot) 
in branch '3.7':
bpo-32087: Doc: Make "deprecated-removed"  directive translatable (GH-4473)
https://github.com/python/cpython/commit/c673a62d5f3c650130bf40f2161a2eac64419bce


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[miss-islington]

Change by miss-islington :


--
pull_requests: +5607

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[miss-islington]

Change by miss-islington :


--
pull_requests: +5606

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[INADA Naoki]

INADA Naoki  added the comment:


New changeset 0febc053736112d7bb9081742b3ac0ece7b973e7 by INADA Naoki 
(cocoatomo) in branch 'master':
bpo-32087: Doc: Make "deprecated-removed"  directive translatable (GH-4473)
https://github.com/python/cpython/commit/0febc053736112d7bb9081742b3ac0ece7b973e7


--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[KINEBUCHI Tomohiko]

Change by KINEBUCHI Tomohiko :


--
keywords: +patch
pull_requests: +4408
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32087] deprecated-removed directive generates overlapping msgids in .pot files

[KINEBUCHI Tomohiko]

New submission from KINEBUCHI Tomohiko :

When gettext builder is invoked, deprecated-removed directive which is defined 
in Doc/tools/extensions/pyspecific.py generates overlapping msgids in .pot 
files.

For example, the following .rst source (taken from Doc/library/dmb.rst L354)::

   .. deprecated-removed:: 3.6 3.8
  Creating database in ``'r'`` and ``'w'`` modes.  Modifying database in
  ``'r'`` mode.

results to following .pot file entries::

   #: ../../library/dbm.rst:357
   msgid "Deprecated since version 3.6, will be removed in version 3.8: 
Creating database in 'r' and 'w' modes.  Modifying database in 'r' mode."
   msgstr ""

   #: ../../library/dbm.rst:357
   msgid "Creating database in ``'r'`` and ``'w'`` modes.  Modifying database 
in ``'r'`` mode."
   msgstr ""

using the command::

   sphinx-build -E -b gettext -D gettext_compact=0  -w warnings.txt -d 
build/.doctrees . locale/pot


The root cause is deprecated-removed directive constructs inappropriate 
sub-doctree for translation.
First, above .rst source is compiled into following tree structure::

   
 
   
 Deprecated since version 3.6, will be removed in version 3.8:
   
 Creating database in...

and gettext builder picks up paragraph node and the second inline node as 
translation targets.

Expected result is that two inline nodes are picked up as translation targets 
and the paragraph node is not, and expected .pot file entries are such as 
following::

   #: ../../library/dbm.rst:357
   msgid "Deprecated since version 3.6, will be removed in version 3.8:"
   msgstr ""

   #: ../../library/dbm.rst:357
   msgid "Creating database in ``'r'`` and ``'w'`` modes.  Modifying database 
in ``'r'`` mode."
   msgstr ""

--
assignee: docs@python
components: Documentation
messages: 306546
nosy: cocoatomo, docs@python
priority: normal
severity: normal
status: open
title: deprecated-removed directive generates overlapping msgids in .pot files
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com