[issue32107] test_uuid uses the incorrect bitmask

STINNER Victor added the comment: The commit 9522a218f7dff95c490ff359cc60e8c2af35f5c8 broke multiple buildbots. Since I don't how to fix it, I reverted it, to get more time to design, implement and test a proper fix. --

[issue32107] test_uuid uses the incorrect bitmask

Change by Barry A. Warsaw : -- pull_requests: +4520 ___ Python tracker ___ ___

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 27, 2017, at 18:38, STINNER Victor wrote: > > STINNER Victor added the comment: > > The commit 9522a218f7dff95c490ff359cc60e8c2af35f5c8 broke multiple buildbots. > Since I don't

[issue32107] test_uuid uses the incorrect bitmask

STINNER Victor added the comment: New changeset c9409f7c4533f75b11a4c44e839d95a1403f8a0a by Victor Stinner in branch 'master': Revert "bpo-32107 - Better merge of #4494 (#4576)" (#4593) https://github.com/python/cpython/commit/c9409f7c4533f75b11a4c44e839d95a1403f8a0a

[issue32107] test_uuid uses the incorrect bitmask

Change by STINNER Victor : -- pull_requests: +4518 ___ Python tracker ___ ___

[issue32107] test_uuid uses the incorrect bitmask

STINNER Victor added the comment: http://buildbot.python.org/all/#/builders/16/builds/252 == FAIL: test_ifconfig_getnode (test.test_uuid.TestInternalsWithoutExtModule)

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 27, 2017, at 16:21, Ned Deily wrote: > > The latest checkin seems to have broken several buildbots: > > http://buildbot.python.org/all/#builders/47/builds/243 >

[issue32107] test_uuid uses the incorrect bitmask

Ned Deily added the comment: The latest checkin seems to have broken several buildbots: http://buildbot.python.org/all/#builders/47/builds/243 http://buildbot.python.org/all/#builders/88/builds/248 http://buildbot.python.org/all/#builders/13/builds/255

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 27, 2017, at 16:08, Serhiy Storchaka wrote: > > We shouldn't check the 42nd bit in maintenance releases. This check will fail > on some computers. Oh, without the preferential return of the universally

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: We shouldn't check the 42nd bit in maintenance releases. This check will fail on some computers. -- ___ Python tracker

[issue32107] test_uuid uses the incorrect bitmask

Change by Barry A. Warsaw : -- pull_requests: +4515 ___ Python tracker ___ ___

[issue32107] test_uuid uses the incorrect bitmask

Change by Barry A. Warsaw : -- pull_requests: +4514 ___ Python tracker ___ ___

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 27, 2017, at 15:18, Serhiy Storchaka wrote: > > My apologies for my dim comment and my obliviousness that leaded to spending > your time on trying to fix a wrong issue. No worries at all. Thanks for working

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: My apologies for my dim comment and my obliviousness that leaded to spending your time on trying to fix a wrong issue. Do you mind to fix the original issue (by removing the wrong check) in maintenance branches? --

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: New changeset 9522a218f7dff95c490ff359cc60e8c2af35f5c8 by Barry Warsaw in branch 'master': bpo-32107 - Better merge of #4494 (#4576) https://github.com/python/cpython/commit/9522a218f7dff95c490ff359cc60e8c2af35f5c8 --

[issue32107] test_uuid uses the incorrect bitmask

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 27, 2017, at 01:24, Serhiy Storchaka wrote: > > 3. Makes methods for getting the address of the real network card preferring > universally administered addresses and falling back to locally administered >

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: Currently PR 4576 combines a bug fix and a new feature. 1. Removes wrong check and adds a verbose clarifying comment. This part should be backported to maintained versions. 2. Adds multiple explicit "return None". This is a

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: PR #4576 includes all related changes. -- ___ Python tracker ___

[issue32107] test_uuid uses the incorrect bitmask

Change by Barry A. Warsaw : -- pull_requests: +4504 ___ Python tracker ___ ___

[issue32107] test_uuid uses the incorrect bitmask

Change by Serhiy Storchaka : -- pull_requests: +4500 ___ Python tracker ___ ___

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: PR 4572 removes the wrong check. -- type: -> behavior versions: +Python 2.7, Python 3.6 ___ Python tracker

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: This is a different issue. -- ___ Python tracker ___

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 26, 2017, at 14:07, Serhiy Storchaka wrote: > > Universally/locally administered MAC addresses doesn't have relation to this > issue. My assumption was about the multicast bit (1<<40). AFAICT, the multicast

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: Universally/locally administered MAC addresses doesn't have relation to this issue. My assumption was about the multicast bit (1<<40). If my assumption was correct, the test is correct, and only the comment should be fixed. If

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 26, 2017, at 12:40, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > If I understand correctly, the original problem was that tests failed in some >

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: If I understand correctly, the original problem was that tests failed in some environments, right? In that case we should either change the environment or just remove this check. I had added it in assumption that it is never

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: I'm sorry, but this tests and the typo were added by me in issue23015. This check is a pair of the check for _random_getnode(). They use the same mask and test the same bit. I forgot about this. --

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 23, 2017, at 11:24, Serhiy Storchaka wrote: > Wait, now I understand the purpose of the current test! There is just a typo > in a comment, should be 41 instead of 47. The test itself is correct. If the >

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: Wait, now I understand the purpose of the current test! There is just a typo in a comment, should be 41 instead of 47. The test itself is correct. If the address is obtained from network cards, it should have the 41 bit clear.

[issue32107] test_uuid uses the incorrect bitmask

STINNER Victor added the comment: > https://travis-ci.org/python/cpython/jobs/305433725 AssertionError: 219902322 is not false : 0242ac110051 AssertionError: 219902322 is not false : 0242ac110051 So the Travis CI MAC address is 02:42:ac:11:00:51. --

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: On Nov 21, 2017, at 15:47, Serhiy Storchaka wrote: > If your fix is correct (and it looks correct to me), we should fix not only > the test, but, first of all, the _*_getnode functions. Perhaps they should > ignore

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: If your fix is correct (and it looks correct to me), we should fix not only the test, but, first of all, the _*_getnode functions. Perhaps they should ignore locally administered MAC addresses and continue searching better

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: Yikes. It's entirely possible that these tests are tainted by environmental leakage. I was looking into why Travis fails on my PR: https://travis-ci.org/python/cpython/jobs/305433725 and stepping through _ifconfig_getnode() on my Mac.

[issue32107] test_uuid uses the incorrect bitmask

Barry A. Warsaw added the comment: Pure chance I believe. It all depends on the MAC address of the machines the test runs on (which is perhaps an unacceptable environmental variability in the test suite, and should be fixed/mocked?). FWIW, I saw the failures on my 2017

[issue32107] test_uuid uses the incorrect bitmask

Serhiy Storchaka added the comment: I'm just wondering why tests were passing successfully before. -- nosy: +serhiy.storchaka ___ Python tracker

[issue32107] test_uuid uses the incorrect bitmask

Change by Barry A. Warsaw : -- keywords: +patch pull_requests: +4431 stage: -> patch review ___ Python tracker ___

[issue32107] test_uuid uses the incorrect bitmask

New submission from Barry A. Warsaw : The check_node() function in test_uuid.py uses the wrong bitmask, causing the tests to fail on valid MAC addresses. Also, the description in the comment is incorrect. From my reading of the wikipedia page, the test is trying to ensure