[issue32147] improve performance of binascii.unhexlify() by using conversion table

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Cheryl Sabella added the comment: Since this PR was merged, can the issue be closed? -- nosy: +cheryl.sabella ___ Python tracker ___

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Serhiy Storchaka added the comment: New changeset 6b5df906afe113dbe421d044322254cfd4747c9c by Serhiy Storchaka (Sergey Fedoseev) in branch 'master': bpo-32147: Improved perfomance of binascii.unhexlify(). (GH-4586)

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Change by Ned Deily : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Meador Inge added the comment: FWIW, I see a win on OS X 10.12.6: λ:[master !?](~/Code/src/python/cpython)=> cc --version Apple LLVM version 8.1.0 (clang-802.0.42) Target: x86_64-apple-darwin16.7.0 Thread model: posix InstalledDir:

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Sergey Fedoseev added the comment: Is there anything I can do to push this forward? BTW, Serhiy, what are your OS, compiler and CPU? -- ___ Python tracker

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Antoine Pitrou added the comment: (platform is Ubuntu 16.04, 64-bit, on a Core i5-2500K CPU) -- ___ Python tracker ___

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Antoine Pitrou added the comment: Here are the results here: - Before: $ ./python -m timeit -s "from binascii import unhexlify; b = b'aa'*2**20" "unhexlify(b)" 50 loops, best of 5: 4.37 msec per loop - After: $ ./python -m timeit -s "from binascii import unhexlify; b =

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Sergey Fedoseev added the comment: > OS x86_64 GNU/Linux > compiler gcc version 7.2.0 (Debian 7.2.0-16) > CPU Architecture:x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s)

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Serhiy Storchaka added the comment: Yes. And I can't reproduce a slowdown with a simplified a2b_qp(). Maybe this depends on the compiler and on the CPU. What are your OS, compiler and CPU? Do you build 32- or 64-bit Python? Do you build in a debug or release mode?

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Sergey Fedoseev added the comment: Serhiy, did you use the same benchmark as mentioned here? -- ___ Python tracker ___

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Serhiy Storchaka added the comment: I can't reproduce the performance difference. -- nosy: +serhiy.storchaka versions: +Python 3.7 ___ Python tracker

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Change by Sergey Fedoseev : -- components: +Library (Lib) ___ Python tracker ___

[issue32147] improve performance of binascii.unhexlify() by using conversion table

Change by Sergey Fedoseev : -- keywords: +patch pull_requests: +4508 stage: -> patch review ___ Python tracker ___

[issue32147] improve performance of binascii.unhexlify() by using conversion table

New submission from Sergey Fedoseev : Before: $ ./python -m timeit -s "from binascii import unhexlify; b = b'aa'*2**20" "unhexlify(b)" 50 loops, best of 5: 5.68 msec per loop After: $ ./python -m timeit -s "from binascii import unhexlify; b = b'aa'*2**20"