[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Cheryl Sabella]

Cheryl Sabella  added the comment:

Since this PR was merged, can the issue be closed?

--
nosy: +cheryl.sabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 6b5df906afe113dbe421d044322254cfd4747c9c by Serhiy Storchaka 
(Sergey Fedoseev) in branch 'master':
bpo-32147: Improved perfomance of binascii.unhexlify(). (GH-4586)
https://github.com/python/cpython/commit/6b5df906afe113dbe421d044322254cfd4747c9c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Ned Deily]

Change by Ned Deily :


--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Meador Inge]

Meador Inge  added the comment:

FWIW, I see a win on OS X 10.12.6:

λ:[master !?](~/Code/src/python/cpython)=> cc --version
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
λ:[master !?](~/Code/src/python/cpython)=> uname -a
Darwin ripley.attlocal.net 16.7.0 Darwin Kernel Version 16.7.0: Wed Oct  4 
00:17:00 PDT 2017; root:xnu-3789.71.6~1/RELEASE_X86_64 x86_64

- Before:
λ:[master ?](~/Code/src/python/cpython)=> ./python.exe -m timeit -s "from 
binascii import unhexlify; b = b'aa'*2**20" "unhexlify(b)"
20 loops, best of 5: 11.3 msec per loop

- After:
λ:[master !?](~/Code/src/python/cpython)=> ./python.exe -m timeit -s "from 
binascii import unhexlify; b = b'aa'*2**20" "unhexlify(b)"
50 loops, best of 5: 4.15 msec per loop

--
nosy: +meador.inge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Sergey Fedoseev]

Sergey Fedoseev  added the comment:

Is there anything I can do to push this forward?

BTW, Serhiy, what are your OS, compiler and CPU?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Antoine Pitrou]

Antoine Pitrou  added the comment:

(platform is Ubuntu 16.04, 64-bit, on a Core i5-2500K CPU)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Here are the results here:

- Before:
$ ./python -m timeit -s "from binascii import unhexlify; b = b'aa'*2**20" 
"unhexlify(b)"
50 loops, best of 5: 4.37 msec per loop

- After:
$ ./python -m timeit -s "from binascii import unhexlify; b = b'aa'*2**20" 
"unhexlify(b)"
200 loops, best of 5: 1.16 msec per loop

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Sergey Fedoseev]

Sergey Fedoseev  added the comment:

> OS
x86_64 GNU/Linux

> compiler
gcc version 7.2.0 (Debian 7.2.0-16)

> CPU
Architecture:x86_64
CPU op-mode(s):  32-bit, 64-bit
Byte Order:  Little Endian
CPU(s):  4
On-line CPU(s) list: 0-3
Thread(s) per core:  2
Core(s) per socket:  2
Socket(s):   1
NUMA node(s):1
Vendor ID:   GenuineIntel
CPU family:  6
Model:   58
Model name:  Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
Stepping:9
CPU MHz: 2494.521
CPU max MHz: 3100,
CPU min MHz: 1200,
BogoMIPS:4989.04
Virtualization:  VT-x
L1d cache:   32K
L1i cache:   32K
L2 cache:256K
L3 cache:3072K
NUMA node0 CPU(s):   0-3
Flags:   fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca 
cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx 
rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology 
nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 
ssse3 cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic popcnt tsc_deadline_timer xsave 
avx f16c rdrand lahf_lm cpuid_fault epb tpr_shadow vnmi flexpriority ept vpid 
fsgsbase smep erms xsaveopt dtherm ida arat pln pts

> Do you build 32- or 64-bit Python?
I'm not sure about that, I guess 64 is default on 64 OS?

> Do you build in a debug or release mode?
I tried with --enable-optimizations, --with-pydebug and without any flags. 
Numbers are different, but magnitude of a change is the same.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Yes. And I can't reproduce a slowdown with a simplified a2b_qp(). Maybe this 
depends on the compiler and on the CPU. What are your OS, compiler and CPU? Do 
you build 32- or 64-bit Python? Do you build in a debug or release mode?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Sergey Fedoseev]

Sergey Fedoseev  added the comment:

Serhiy, did you use the same benchmark as mentioned here?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I can't reproduce the performance difference.

--
nosy: +serhiy.storchaka
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Sergey Fedoseev]

Change by Sergey Fedoseev :


--
components: +Library (Lib)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Sergey Fedoseev]

Change by Sergey Fedoseev :


--
keywords: +patch
pull_requests: +4508
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32147] improve performance of binascii.unhexlify() by using conversion table

[Sergey Fedoseev]

New submission from Sergey Fedoseev :

Before:

$ ./python -m timeit -s "from binascii import unhexlify; b = b'aa'*2**20" 
"unhexlify(b)"
50 loops, best of 5: 5.68 msec per loop

After:

$ ./python -m timeit -s "from binascii import unhexlify; b = b'aa'*2**20" 
"unhexlify(b)"
100 loops, best of 5: 2.06 msec per loop

--
messages: 307053
nosy: sir-sigurd
priority: normal
severity: normal
status: open
title: improve performance of binascii.unhexlify() by using conversion table
type: performance

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com