[issue32150] Expand tabs to spaces in C files

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Guido! I think now we can revive issue8912. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32150] Expand tabs to spaces in C files

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 598ceae876ff4a23072e59945597e945583de4ab by Serhiy Storchaka in branch 'master': bpo-32150: Expand tabs to spaces in C files. (#4583)

[issue32150] Expand tabs to spaces in C files

2017-11-28 Thread Guido van Rossum
Guido van Rossum added the comment: OK, so I think you can go ahead with this. I was fine with the state of the patch yesterday, so whatever you added today is also fine. -- ___ Python tracker

[issue32150] Expand tabs to spaces in C files

2017-11-27 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah, some editors don't clean up trailing ws. Even with Emacs it occasionally happens to me. -- ___ Python tracker

[issue32150] Expand tabs to spaces in C files

2017-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Tools/scripts/patchcheck.py does this check. It is used for .py and .rst files, and there is issue8912 for applying it to .c/.h files. patchcheck.py also checks trailing whitespaces. While I and other core developers constantly

[issue32150] Expand tabs to spaces in C files

2017-11-27 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe we also need (in a separate PR) a git pre-commit hook that prevents tabs in the source (except in the few exceptions you left alone). -- ___ Python tracker

[issue32150] Expand tabs to spaces in C files

2017-11-27 Thread Guido van Rossum
Guido van Rossum added the comment: I think I'm cool with this (even though it will make blame-finding on GitHub a tad harder -- what's the magic URL appendage again?) -- ___ Python tracker

[issue32150] Expand tabs to spaces in C files

2017-11-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4512 ___ Python tracker ___

[issue32150] Expand tabs to spaces in C files

2017-11-27 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : While most C files use spaces for indenting and aligning, there are few sites in which tabs are left. Sometimes mixed tabs and spaces are used in the same file. This adds a noise in the diff if the committer uses an editor