[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

STINNER Victor added the comment: The main bugs have been fixed in Python 3.6 and 3.7 (master). Python 2.7 only has the bug in Tools/scripts/treesync.py, but I don't think that it's worth it to fix this old script in the stable 2.7 branch. I just removed this script

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

STINNER Victor added the comment: New changeset 71bd588646b282c9eebc390b31184a5bdb54e712 by Victor Stinner in branch 'master': bpo-32155: Revert distutils.config change (#4618) https://github.com/python/cpython/commit/71bd588646b282c9eebc390b31184a5bdb54e712

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

STINNER Victor added the comment: New changeset 6979fcdc91114b1ccb16345e26734d6df4cccbc3 by Victor Stinner in branch '3.6': bpo-32155: Bugfixes found by flake8 F841 warnings (#4619) https://github.com/python/cpython/commit/6979fcdc91114b1ccb16345e26734d6df4cccbc3

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

Change by STINNER Victor : -- pull_requests: +4533 ___ Python tracker ___ ___

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

STINNER Victor added the comment: I proposed PR 4618 to revert the distutils.config changes. -- ___ Python tracker ___

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

Change by STINNER Victor : -- pull_requests: +4532 ___ Python tracker ___ ___

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

Éric Araujo added the comment: The best course of action would be to revert the distutils changes. There are a handful of tickets related to register/upload commands, which are funky commands with their own config file not 100% in line with other distutils commands.

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

Berker Peksag added the comment: I don't think distutils changes are correct. ('realm', self.DEFAULT_REALM) 'realm' is the config name and 'self.DEFAULT_REALM' is its default value. In the 'for key, default in ...:' loop, 1. It checks if it's already set in the

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

STINNER Victor added the comment: > If you have replaced self.DEFAULT_REALM with realm why not replace > self.DEFAULT_REPOSITORY with repository? Oh, I didn't notice that there is also a repository variable which is not used in all code paths. > I don't know what

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

Serhiy Storchaka added the comment: If you have replaced self.DEFAULT_REALM with realm why not replace self.DEFAULT_REPOSITORY with repository? I don't know what is correct. Added distutils experts for review. -- nosy: +dstufft, eric.araujo,

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

Change by Roundup Robot : -- pull_requests: +4526 ___ Python tracker ___

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

STINNER Victor added the comment: New changeset 696b501cd11dc429a0f661adeb598bfaf89e4112 by Victor Stinner in branch 'master': bpo-32155: Bugfixes found by flake8 F841 warnings (#4608) https://github.com/python/cpython/commit/696b501cd11dc429a0f661adeb598bfaf89e4112

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

Change by STINNER Victor : -- keywords: +patch pull_requests: +4524 stage: -> patch review ___ Python tracker ___

[issue32155] Fix flake8 warning F841: local variable ... is assigned to but never used

New submission from STINNER Victor : Using flake8, I found some bugs in the standard libraries and tools. I already fixed another flake8 error: --- commit 28e61650b23119b68cd7943ccc01b8b9af1b4103 Author: Victor Stinner Date: Tue Nov 28