[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Victor! I'll open a topic on Python-Dev about file removals. -- resolution: fixed -> stage: resolved -> patch review status: closed -> open ___ Python tracker

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread STINNER Victor
STINNER Victor added the comment: I reverted Misc/svnmap.txt. I understood that the removal of the two tools in Tools is now ok, and so I close the issue. If I misunderstood, please speak up and/or reopen the issue ;-) -- resolution: -> fixed stage: patch

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread STINNER Victor
STINNER Victor added the comment: New changeset 859f7ce7a49f8bd6309748c05e460c10f6a433ed by Victor Stinner in branch 'master': bpo-32159: Revert Misc/svnmap.txt (#4639) https://github.com/python/cpython/commit/859f7ce7a49f8bd6309748c05e460c10f6a433ed --

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread STINNER Victor
STINNER Victor added the comment: > How have you created PR 4639? What git commands were used? "git revert fe2d5babba5d26de2093b6518316b268488187be", then I modified the commit to only revert svnmap (git commit --amend). Git internal storage is fully based on sha1.

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: How have you created PR 4639? What git commands were used? -- ___ Python tracker ___

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: "Wouldn't this add two 4 MiB patched in the git repository? Wouldn't this break the history of this file?" No idea. -- ___ Python tracker

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Wouldn't this add two 4 MiB patched in the git repository? Wouldn't this break the history of this file? -- ___ Python tracker

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread STINNER Victor
STINNER Victor added the comment: When I wrote PR 4615, I misunderstood the usage of Misc/svnmap.txt. I understood that it was used by removed files. I wrote PR 4639 to revert the file and clarify its usage in Misc/README. --

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +4553 ___ Python tracker ___ ___

[issue32159] Remove tools for CVS and Subversion

2017-11-29 Thread R. David Murray
R. David Murray added the comment: I think Serhiy's point is that it doesn't matter whether or not it is used by a tool, it is useful for humans. I don't know if it is used by the tracker; Ezio worked on that code, I think. --

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread Ned Deily
Ned Deily added the comment: Sorry, I didn't see that the change included the deletion of svnmap.txt. However, I don't know where or by what that file might still be used, particularly by the lookup function used by the bug tracker. Presumably someone (Ezio, RDM, or Brett)

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: svnmap.txt was added in a single revision and was not changed anymore. commit 533c79dc67824d95b0aff5a252f9415d3bc80716 Author: Antoine Pitrou Date: Sat Mar 5 17:46:03 2011 +0100 Add the map of SVN

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: "Is svnmap.txt used for mapping Subversion references to Mercurial references on the tracker? r88752" Brett, David, Ezio: any idea for Serhiy's question? -- nosy: +brett.cannon, ezio.melotti, r.david.murray

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Is svnmap.txt used for mapping Subversion references to Mercurial references on the tracker? r88752 -- ___ Python tracker

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread STINNER Victor
STINNER Victor added the comment: > The PR was approved by Brett Cannon and Ned Deily. Oh, and Mariatta after I added a NEWS entry. -- ___ Python tracker

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread STINNER Victor
STINNER Victor added the comment: > Are you sure that these scripts are not used outside of CPython? How would someone use it? There are only part of the code base, they are not installed on the system (by "make install"). If someone uses these scripts on another

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, you are VERY fast in committing Victor. Please restore these scripts. -- ___ Python tracker

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Are you sure that these scripts are not used outside of CPython? They were here when CPython used Subversion, they were here when CPython used Mercurial, what is wrong with Git? The support of the svn:eol property is a thing I

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread STINNER Victor
STINNER Victor added the comment: New changeset fe2d5babba5d26de2093b6518316b268488187be by Victor Stinner in branch 'master': bpo-32159: Remove tools for CVS and Subversion (#4615) https://github.com/python/cpython/commit/fe2d5babba5d26de2093b6518316b268488187be

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +4531 stage: -> patch review ___ Python tracker ___

[issue32159] Remove tools for CVS and Subversion

2017-11-28 Thread STINNER Victor
New submission from STINNER Victor : CPython migrated from CVS to Subversion, to Mercurial, and then to Git. CVS and Subversion are no more used to develop CPython. Changes of attached PR: * platform module: drop support for sys.subversion. The sys.subversion