[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[STINNER Victor]

STINNER Victor  added the comment:

> Thank you Andrew! This have made the code cleaner.

Yeah! I really love to see old these old crappy legacy stuff to go away. The 
asyncio code behave shorter, simpler and with less "#ifdef" ;-)

I understand that the Python language and stdlib became better the last 2-3 
years ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[Andrew Svetlov]

Andrew Svetlov  added the comment:

You are welcome!
Thanks for review

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you Andrew! This have made the code cleaner.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[Andrew Svetlov]

Andrew Svetlov  added the comment:


New changeset cc83920ad267c992bc421987829da04d88ae816b by Andrew Svetlov in 
branch 'master':
bpo-32166: Drop Python 3.4 code from asyncio (#4612)
https://github.com/python/cpython/commit/cc83920ad267c992bc421987829da04d88ae816b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Fixed unix_events.py but see no legacy code in futures.py and sslproto.py.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[Andrew Svetlov]

Change by Andrew Svetlov :


--
Removed message: https://bugs.python.org/msg307226

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Ok, will do everything in single PR

--
title: Drop python 3.4 code from asyncio.coroutines -> Drop python 3.4 code 
from asyncio.coroutines and asyncio.unix_events

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Ok, will do everything in single PR

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I would prefer to do all trivial changes with one commit.

There may be also non-trivial changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Andrew Svetlov]

Change by Andrew Svetlov :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Separate PyPI package is for Python 3.3 only.
Python 3.4 is shipped with asyncio in standard batteries.

https://github.com/python/asyncio development is stopped, no new PyPI release 
is expected.

Thank you for pointing on 3.4 specific code in other files.

Victor Stinner did some cleanup in last weeks, I've picked up his initiative.

Will review other files as well.
Please let me create a new issue to keep changes small and modular.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

If it is good to drop 3.4 support in the stdlib asyncio, then there is other 
outdated code.

There is a 3.3 specific workaround in unix_events.py.

There is a 3.4 code or comments in futures.py, sslproto.py, unix_events.py. 
Maybe comments are related to optional code which can now be used 
unconditionally.

Note that not all 3.4 code is marked with "Python 3.4". It can be marked with 
"Python < 3.5".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I support getting rid of outdated code.

But what is relation between asyncio in the stdlib and the version outside of 
the stdlib? Shouldn't the code support old Python versions for easier 
synchronization? I remember in the past this prevented modernizing it.

The support of 3.4 is important, since this is a version shipped with Ubuntu 
16.04 LTS. This will be a main version for enterprise at least yet a year.

--
nosy: +giampaolo.rodola, gvanrossum, serhiy.storchaka, vstinner
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Andrew Svetlov]

Change by Andrew Svetlov :


--
keywords: +patch
pull_requests: +4548
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32166] Drop python 3.4 code from asyncio.coroutines

[Andrew Svetlov]

New submission from Andrew Svetlov :

Dropped lines are never executed by supported Python versions.
The code exists for sake of keeping the same code base for stdlib asyncio and 
third-party library with the same name.
Since Python 3.4 asyncio is a part of stdlib, asyncio on PyPI is not 
supported/updated for 2.5 years.
Removing is safe.

The change keeps backward compatibility with old libraries written for `yield 
from` syntax, both awaiting old-styled coroutines and yielding from new styles 
async functions are supported.

async def f():
...
yield from f()

@asyncio.coroutine
def g():
...
await g()

Thus no regressions/deprecations, just removing non-public never executed 
implementation details.

--
assignee: asvetlov
components: Library (Lib), asyncio
messages: 307214
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: Drop python 3.4 code from asyncio.coroutines
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com