[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Now that the zipimporter support has landed, I think we're done!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:


New changeset 6f6eb35f9bee18f54945f09664344f2d118ed89f by Barry Warsaw in 
branch 'master':
 bpo-32248 - Implement `ResourceReader` and `get_resource_reader()` for 
zipimport (#5248)
https://github.com/python/cpython/commit/6f6eb35f9bee18f54945f09664344f2d118ed89f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
pull_requests: +5093

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 3a0cf931796b9ad1b4833ab89c79d284b4253c91 by Victor Stinner in 
branch 'master':
bpo-32248: Fix test_importlib.test_open() (#5213)
https://github.com/python/cpython/commit/3a0cf931796b9ad1b4833ab89c79d284b4253c91


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +5067

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 44a70e9336765404057b12345465844dc291297a by Victor Stinner in 
branch 'master':
Fix Git attributes of test_importlib data files (#5209)
https://github.com/python/cpython/commit/44a70e9336765404057b12345465844dc291297a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
pull_requests:  -5016

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +5064

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Brett Cannon]

Brett Cannon  added the comment:


New changeset bca42186b69e2e615d29d0d4fdb493c9fe71c48b by Brett Cannon in 
branch 'master':
bpo-32248: Introduce the concept of Loader.get_resource_reader() (GH-5108)
https://github.com/python/cpython/commit/bca42186b69e2e615d29d0d4fdb493c9fe71c48b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[bbayles]

Change by bbayles :


--
pull_requests: +5016

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
pull_requests:  -5006

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

@bbayles: I don't think PR 5149 is related to this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[bbayles]

Change by bbayles :


--
pull_requests: +5006

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +4998

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[STINNER Victor]

STINNER Victor  added the comment:

Failure on x86 Gentoo Installed with X 3.x:

http://buildbot.python.org/all/#/builders/103/builds/453

4 tests failed:
test_compileall test_import test_importlib test_inspect

test test_import crashed -- Traceback (most recent call last):
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/test/libregrtest/runtest.py",
 line 163, in runtest_inner
the_module = importlib.import_module(abstest)
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/importlib/__init__.py",
 line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
  File "", line 994, in _gcd_import
  File "", line 971, in _find_and_load
  File "", line 955, in _find_and_load_unlocked
  File "", line 665, in _load_unlocked
  File "", line 723, in exec_module
  File "", line 219, in _call_with_frames_removed
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/test/test_import/__init__.py",
 line 28, in 
from test.test_importlib.util import uncache
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/test/test_importlib/util.py",
 line 19, in 
from . import data01
ImportError: cannot import name 'data01' from 'test.test_importlib' 
(/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/test/test_importlib/__init__.py)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[STINNER Victor]

STINNER Victor  added the comment:

Tests fail on Windows since the commit deae6b451fefd5fd3143dd65051e1d341e5a5f84.

Example with AMD64 Windows8.1 Non-Debug 3.x:

http://buildbot.python.org/all/#/builders/12/builds/426

==
FAIL: test_open_binary (test.test_importlib.test_open.OpenDiskTests)
--
Traceback (most recent call last):
  File 
"D:\buildarea\3.x.ware-win81-release\build\lib\test\test_importlib\test_open.py",
 line 24, in test_open_binary
self.assertEqual(result, b'Hello, UTF-8 world!\n')
AssertionError: b'Hello, UTF-8 world!\r\n' != b'Hello, UTF-8 world!\n'

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

On Jan 6, 2018, at 13:33, Zachary Ware  wrote:
> 
> I notice that my 'Installed' builder 
> (http://buildbot.python.org/all/#/builders/103) has been broken since PR4911 
> landed.  My suspicion is that it's just another directory missed in the 
> Makefile install libinstall target, but haven't actually looked into it.

Dang.  I’ll try to look into this as soon as possible, but it might be a day or 
so.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Brett Cannon]

Brett Cannon  added the comment:

I bet Barry forgot to add some test directories to the makefile.

On Sat, Jan 6, 2018, 10:33 Zachary Ware,  wrote:

>
> Zachary Ware  added the comment:
>
> I notice that my 'Installed' builder (
> http://buildbot.python.org/all/#/builders/103) has been broken since
> PR4911 landed.  My suspicion is that it's just another directory missed in
> the Makefile install libinstall target, but haven't actually looked into it.
>
> --
> nosy: +zach.ware
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Zachary Ware]

Zachary Ware  added the comment:

I notice that my 'Installed' builder 
(http://buildbot.python.org/all/#/builders/103) has been broken since PR4911 
landed.  My suspicion is that it's just another directory missed in the 
Makefile install libinstall target, but haven't actually looked into it.

--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Brett Cannon]

Change by Brett Cannon :


--
pull_requests: +4975

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[David Bolen]

David Bolen  added the comment:

Apologies if this is obvious and already in progress, but the issue with 
Windows and this change appears to be that the "utf-8.file" file is being 
treated as text rather than binary.

So the line ending is expanding to CRLF.  The working copy of utf-8.file on my 
Windows workers is actually 21 bytes, not 20.

--
nosy: +db3l

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Next up - implementing the ResourceReader ABC.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:


New changeset deae6b451fefd5fd3143dd65051e1d341e5a5f84 by Barry Warsaw in 
branch 'master':
bpo-32248 - Implement importlib.resources (#4911)
https://github.com/python/cpython/commit/deae6b451fefd5fd3143dd65051e1d341e5a5f84


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Eric Snow]

Change by Eric Snow :


--
nosy: +eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Brett Cannon]

Brett Cannon  added the comment:

Yep, I assumed implementing the ReourceReader API would be a separate step.

As for the type hints, I thought it was lifted such that new code could include 
it but we wouldn't be taking PRs to add them to pre-existing code?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

PR 4911 implements the importlib.resources API, along with tests and 
documentation.

@brett.cannon - I'm thinking we should do the native ResourceReader 
implementations for the built-in loaders as a separate branch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
pull_requests: +4805

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

I have the tests and code ported, but there are still a few things to do, but 
here's a question:

We're using type annotations in importlib_resources, which of course is the 
right decision.  But I think we still have a moratorium on typing in the 
stdlib.  So do we want to remove the types from importlib.resources?

Doing so could make for more work as we continue to track importlib_resource, 
so I'm inclined not to remove them.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Brett Cannon]

Brett Cannon  added the comment:


New changeset 4ac5150e068a3a795ef00465f6dff51747b62b91 by Brett Cannon in 
branch 'master':
bpo-32248: Implement importlib.abc.ResourceReader (GH-4892)
https://github.com/python/cpython/commit/4ac5150e068a3a795ef00465f6dff51747b62b91


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Brett Cannon]

Change by Brett Cannon :


--
keywords: +patch
pull_requests: +4785
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Gregory P. Smith]

Change by Gregory P. Smith :


--
nosy: +gregory.p.smith, twouters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

[Barry A. Warsaw]

New submission from Barry A. Warsaw :

We intend to port importlib_resources to Python 3.7 as importlib.resources, 
with a provisional API.  There's also a ResourceReader ABC to include, along 
with documentation and tests.

Nosying Brett and assigning to myself, but if Brett *wants* to do the work, I 
won't stand in his way. :)

--
assignee: barry
components: Library (Lib)
messages: 307824
nosy: barry, brett.cannon
priority: normal
severity: normal
status: open
title: Port importlib_resources (module and ABC) to Python 3.7
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com