[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset d1cb1067a82b11280204e36b695e786a5a3ca221 by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.6':
bpo-32277: Fix exception raised from chmod(..., follow_symlinks=False) 
(GH-4797) (#4869)
https://github.com/python/cpython/commit/d1cb1067a82b11280204e36b695e786a5a3ca221


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I was going to request a test, but the fix is obvious and writing a test for 
this case can be not easy. Thank you Anthony for your report and patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4761

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 233ef249cc5c18d796fb581747179c5e062b4083 by Serhiy Storchaka 
(Anthony Sottile) in branch 'master':
bpo-32277: Fix exception raised from chmod(..., follow_symlinks=False) (#4797)
https://github.com/python/cpython/commit/233ef249cc5c18d796fb581747179c5e062b4083


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Anthony Sottile]

Anthony Sottile  added the comment:

I noticed it when I changed the test preconditions in 
https://github.com/python/cpython/pull/4783

I tried changing a test to trigger this (in this branch) but I found I was just 
implementing exactly the test in the `skip` condition which to me didn't feel 
like a very valuable test.

>From what I can tell, the current testsuite passes on my machine before and 
>after this change -- only with the small reproduction.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +Extension Modules
type:  -> behavior
versions:  -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Does any existing test failed on such platform?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Anthony Sottile]

Change by Anthony Sottile :


--
keywords: +patch
pull_requests: +4696
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32277] SystemError via chmod(symlink, ..., follow_symlinks=False)

[Anthony Sottile]

New submission from Anthony Sottile :

While investigating https://bugs.python.org/issue31940 I noticed the following 
is raised as `SystemError` instead of the expected `NotImplementedError`

(note: you need a platform with fchmodat but does not support nofollow)

```
touch foo
ln -s foo bar
python3.6 -c 'import os; os.chmod("bar", 0o666, follow_symlinks=False)
```

Expected: raised `NotImplementedError`
Actual: raised `SystemError`

--
messages: 308062
nosy: Anthony Sottile
priority: normal
severity: normal
status: open
title: SystemError via chmod(symlink, ..., follow_symlinks=False)
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com