[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[miss-islington]

miss-islington  added the comment:


New changeset 01dd52fb29566893dde59dea7bca582625c04762 by Miss Islington (bot) 
in branch '3.7':
bpo-32556: nt._getfinalpathname, nt._getvolumepathname and nt._getdiskusage now 
correctly convert from bytes. (GH-5761)
https://github.com/python/cpython/commit/01dd52fb29566893dde59dea7bca582625c04762


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[miss-islington]

Change by miss-islington :


--
pull_requests: +5591

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[Steve Dower]

Steve Dower  added the comment:


New changeset 23ad6d0d1a7a6145a01494f4f3913a63d1f0250c by Steve Dower in branch 
'master':
bpo-32556: nt._getfinalpathname, nt._getvolumepathname and nt._getdiskusage now 
correctly convert from bytes. (GH-5761)
https://github.com/python/cpython/commit/23ad6d0d1a7a6145a01494f4f3913a63d1f0250c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[Steve Dower]

Change by Steve Dower :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +5539
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[Steve Dower]

Change by Steve Dower :


--
assignee:  -> steve.dower
stage: patch review -> needs patch
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32556] support bytes paths in nt _getdiskusage, _getvolumepathname, and _getfinalpathname

[Eryk Sun]

New submission from Eryk Sun :

In issue 26330 it was noted that nt._getdiskusage doesn't accept bytes paths. 
The same applies to nt._getvolumepathname and nt._getfinalpathname. Callers of 
these functions shouldn't have to manually implement PEP 529 UTF-8 support to 
handle input and output bytes paths. 

On the other hand, nt._getfullpathname works with a bytes path since it takes a 
`path_t` argument instead of `unicode` or `Py_UNICODE`. The above 3 functions 
could be rewritten to use `path_t` for the input path, and then encode the 
output path via PyUnicode_EncodeFSDefault if path->narrow is set.

--
components: Library (Lib), Unicode, Windows
messages: 309990
nosy: eryksun, ezio.melotti, paul.moore, steve.dower, tim.golden, vstinner, 
zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: support bytes paths in nt _getdiskusage, _getvolumepathname, and 
_getfinalpathname
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com