[issue32585] Add ttk::spinbox to tkinter.ttk

Alan Moore added the comment: Thank you for all your help! On 02/09/2018 05:41 AM, Serhiy Storchaka wrote: > Serhiy Storchaka added the comment: > > Thank you for your contribution Alan! > > -- > resolution: -> fixed > stage: patch

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: Thank you for your contribution Alan! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: New changeset 105fcbfd6a91abea0ecd71e53651f39ad6f6039b by Serhiy Storchaka (Miss Islington (bot)) in branch '3.7': bpo-32585: Add tkinter.ttk.Spinbox. (GH-5221) (GH-5592)

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: New changeset a48e78a0b7761dd74f1d03fc69e0f6caa6f02fe6 by Serhiy Storchaka (Alan D Moore) in branch 'master': bpo-32585: Add tkinter.ttk.Spinbox. (#5221)

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: Thank you Ned. -- ___ Python tracker ___

[issue32585] Add ttk::spinbox to tkinter.ttk

Change by miss-islington : -- pull_requests: +5410 stage: commit review -> patch review ___ Python tracker ___

[issue32585] Add ttk::spinbox to tkinter.ttk

Ned Deily added the comment: It is past the feature code cutoff for 3.7.0 but the risks seem low and the benefit reasonably high. Please make sure it is merged ASAP to allow time for buildbot exposure, etc, prior to 370b2. -- stage: test needed -> commit review

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: All tests are passed. Ned, is it possible to get this feature in 3.7? I didn't have possibility to merge it before 3.7b1. This is just an addition of a simple class. It should be added years ago, it was not added before just

[issue32585] Add ttk::spinbox to tkinter.ttk

Alan Moore added the comment: Thanks, I'm guessing  the update_idletasks() needed to be called after changing the value of command, since the button clicks do this as part of the method. If that's not right, let me know. I've added the options to the list and pushed the

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: I have fixed tests on HiDPI displays. Two issues are left: 1. test_command still fails randomly. Seems adding update_idletasks() invocation fixes this. And calling pack() looks redundant. 2. Following warnings are emitted:

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: If set DPI to low value, the size of a spinbox widget (winfo_width(), winfo_height()) is (185, 20), and the test is passed. If set it to high value, the size is (305, 30), and the test is failed. --

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: This is because of HiDPI display. Mouse events are generated with pixel coordinates (x=width - 5, y=5), but these coordinates are out of a button on scaled widget. -- ___ Python

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: Tests that are failing on my computer: == FAIL: test_command (tkinter.test.test_ttk.test_widgets.SpinboxTest)

[issue32585] Add ttk::spinbox to tkinter.ttk

Serhiy Storchaka added the comment: Needed tests, documentation, etc. -- ___ Python tracker ___

[issue32585] Add ttk::spinbox to tkinter.ttk

Terry J. Reedy added the comment: As said in review, I would like to see this added unless there is a good reason for the omission. Still needed are patches for doc and tests. -- nosy: +serhiy.storchaka, terry.reedy stage: patch review -> test needed

[issue32585] Add ttk::spinbox to tkinter.ttk

Change by Roundup Robot : -- keywords: +patch pull_requests: +5072 stage: -> patch review ___ Python tracker ___

[issue32585] Add ttk::spinbox to tkinter.ttk

New submission from Alan Moore : Ttk has a spinbox widget, which is a themed version of Tkinter spinbox, but this is missing from Python's ttk implementation. -- components: Tkinter messages: 310198 nosy: Alan Moore priority: normal severity: normal status: open