[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)

2018-05-14 Thread St├ęphane Wirtel
St├ęphane Wirtel added the comment: Hi, For the wording, I have no suggestions but seems to be fine. For the rest, I think you have modified the documentation and it's fine and we don't talk about the code. We could merge the PR for the documentation and maybe you could

[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)

2018-02-12 Thread Fangyi Zhou
Fangyi Zhou added the comment: Hi. I've updated the docs. I'm wondering if the code needs to be patched as well. Essentially we should raise a unified Exception for unable to get the username I suppose? Please let me know if you have any comments/suggestions on

[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)

2018-02-10 Thread Fangyi Zhou
Change by Fangyi Zhou : -- keywords: +patch pull_requests: +5426 stage: needs patch -> patch review ___ Python tracker ___

[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)

2018-01-31 Thread Yaron de Leeuw
Yaron de Leeuw added the comment: What kind of exception did you have in mind? As the 'someone' you mentioned, I can contribute this. btw, os.getuid() on windows raises an attribute error, so we need to check that too. -- ___

[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)

2018-01-31 Thread Yaron de Leeuw
Change by Yaron de Leeuw : -- nosy: +jarondl ___ Python tracker ___ ___ Python-bugs-list

[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)

2018-01-31 Thread Gregory P. Smith
New submission from Gregory P. Smith : This has been true since Python 1.x. getpass.getuser() is documented as "raising an exception" but doesn't specify what exception. On Windows when the environment variables it looks at are not set, an ImportError (!) escapes due to