[issue32829] Lib/ be more pythonic

[R. David Murray]

R. David Murray  added the comment:

The risk of introducing a bug is higher than the minimal benefit of making the 
changes.  Thus we do not typically accept changes like this.  We'll clean up 
such code when we touching it for other reasons.

--
nosy: +r.david.murray
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32829] Lib/ be more pythonic

[Дилян Палаузов]

Дилян Палаузов  added the comment:

The variables got_it in distutils/command/sdist and quote in 
email/_header_value_parser can be skipped making the code shorter and faster.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32829] Lib/ be more pythonic

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Dilyan, please explain what you believe the problems to be and how the patch 
solves it.  These seem to be 3 separate issues.

Do not change idlelib.config.  config_main.def contain 'default = True' or 
'default = False' and that is what the docstring references.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32829] Lib/ be more pythonic

[Christian Heimes]

Christian Heimes  added the comment:

We generally don't accept patches on bugs.python.org. Please open a pull 
request on github, see https://devguide.python.org/#contributing

--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32829] Lib/ be more pythonic

[Дилян Палаузов]

New submission from Дилян Палаузов :

diff --git a/Lib/distutils/command/sdist.py b/Lib/distutils/command/sdist.py
--- a/Lib/distutils/command/sdist.py
+++ b/Lib/distutils/command/sdist.py
@@ -251,14 +251,11 @@ class sdist(Command):
 for fn in standards:
 if isinstance(fn, tuple):
 alts = fn
-got_it = False
 for fn in alts:
 if self._cs_path_exists(fn):
-got_it = True
 self.filelist.append(fn)
 break
-
-if not got_it:
+else:
 self.warn("standard file not found: should have one of " +
   ', '.join(alts))
 else:
diff --git a/Lib/email/_header_value_parser.py 
b/Lib/email/_header_value_parser.py
--- a/Lib/email/_header_value_parser.py
+++ b/Lib/email/_header_value_parser.py
@@ -567,14 +567,7 @@ class DisplayName(Phrase):
 
 @property
 def value(self):
-quote = False
-if self.defects:
-quote = True
-else:
-for x in self:
-if x.token_type == 'quoted-string':
-quote = True
-if quote:
+if self.defects or any(x.token_type == 'quoted-string' for x in self):
 pre = post = ''
 if self[0].token_type=='cfws' or self[0][0].token_type=='cfws':
 pre = ' '
diff --git a/Lib/idlelib/config.py b/Lib/idlelib/config.py
--- a/Lib/idlelib/config.py
+++ b/Lib/idlelib/config.py
@@ -402,7 +402,7 @@ class IdleConf:
 because setting 'name' to a builtin not defined in older IDLEs
 to display multiple error messages or quit.
 See https://bugs.python.org/issue25313.
-When default = True, 'name2' takes precedence over 'name',
+When default is True, 'name2' takes precedence over 'name',
 while older IDLEs will just use name.  When default = False,
 'name2' may still be set, but it is ignored.
 """

--
components: Build
messages: 312040
nosy: dilyan.palauzov
priority: normal
severity: normal
status: open
title: Lib/ be more pythonic
type: performance
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com