[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Serhiy Storchaka added the comment: New changeset 3a04598f63960e72025a91c682aec51b6b460413 by Serhiy Storchaka (Cheryl Sabella) in branch '2.7': bpo-32857: Raise error when tkinter after_cancel() is called with None. (GH-5701) (GH-6620)

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Change by Cheryl Sabella : -- pull_requests: +6316 ___ Python tracker ___ ___

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

miss-islington added the comment: New changeset a5303dd9c263b337f02dda0038f2f5a10208140c by Miss Islington (bot) in branch '3.7': bpo-32857: Raise error when tkinter after_cancel() is called with None. (GH-5701)

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

miss-islington added the comment: New changeset 73a43960c7be50e136c5482404980175cb99f611 by Miss Islington (bot) in branch '3.6': bpo-32857: Raise error when tkinter after_cancel() is called with None. (GH-5701)

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Change by miss-islington : -- pull_requests: +5739 ___ Python tracker ___

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Change by miss-islington : -- pull_requests: +5738 ___ Python tracker ___

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Serhiy Storchaka added the comment: New changeset 74382a3f175ac285cc924a73fd758e8dc3cc41bb by Serhiy Storchaka (Cheryl Sabella) in branch 'master': bpo-32857: Raise error when tkinter after_cancel() is called with None. (GH-5701)

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Cheryl Sabella added the comment: I've added the tests for `after` and `after_idle`. I used `update` and `update_idletasks` to make sure they processed. Even scheduling an after event for 0 ms didn't guarantee it would process, but I wasn't sure if there was a better way

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Serhiy Storchaka added the comment: It's up to you. -- ___ Python tracker ___

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Cheryl Sabella added the comment: I had also noticed that the `after` commands didn't have tests. Did you want me to add tests in a separate issue before this one is merged or did you want me to add tests under this PR? Thanks! --

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Serhiy Storchaka added the comment: I have noticed that there are no tests for after() and after_cancel(). Maybe first write tests for them and later add a test for this specific issue to them? -- ___ Python tracker

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Change by Cheryl Sabella : -- keywords: +patch pull_requests: +5490 stage: needs patch -> patch review ___ Python tracker ___

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Change by Serhiy Storchaka : -- stage: -> needs patch versions: +Python 2.7, Python 3.6, Python 3.7 ___ Python tracker ___

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Serhiy Storchaka added the comment: I prefer the option 1. Even if calling after_cancel(None) would make sense, currently it silently does wrong things, and it is more errorproof to make it raising an exception. -- nosy: +serhiy.storchaka

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

Cheryl Sabella added the comment: I can open a PR for this, but thought it might be best to discuss it first as far as what should happen with None. 1. Raise an error that it's an incorrect call. 2. Ignore it and just return. 3. Loop through all the events and after_cancel

[issue32857] tkinter after_cancel does not behave correctly when called with id=None

New submission from Cheryl Sabella : This was discovered while working on issue32839. An old comment added for issue763637 resulted in further research and it was determined that the comment: ! data = self.tk.call('after', 'info', id) ! # In Tk 8.3,