[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset b0f387d7ca126d486fc82744b8ec90c131230311 by Serhiy Storchaka in 
branch '3.7':
[3.7] bpo-33031: Remove dead code in C implementation of OrderedDict. (GH-6120) 
(GH-6433)
https://github.com/python/cpython/commit/b0f387d7ca126d486fc82744b8ec90c131230311


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +6129

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 827d49f3cf0296f1e267eae6834a977cf312cc1e by Serhiy Storchaka in 
branch 'master':
bpo-33031: Remove dead code in C implementation of OrderedDict. (GH-6120)
https://github.com/python/cpython/commit/827d49f3cf0296f1e267eae6834a977cf312cc1e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +5884
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
stage: patch review -> 
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33031] Questionable code in OrderedDict definition

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

The array of PyMethodDef for OrderedDict contains explicit definitions of 
methods like __delitem__, __eq__ and __init__. The purpose is aligning 
docstrings with Python implementation. But this doesn't work. Slot wrappers 
replace these descriptors. And docstings are standard docstrings for 
corresponding slot wrappers.

Thus this code doesn't work. And it looks dangerous, since functions are casted 
to incompatible function types. Even if they are never used, the compiler (gcc 
8) produces warnings (see issue33012). May be this is even undefined behavior. 
In that case the compiler can generate arbitrary code.

I suggest to remove these definitions.

--
components: Extension Modules
messages: 313452
nosy: eric.snow, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Questionable code in OrderedDict definition
type: compile error
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com