[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-04 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

Yes, but we're not losing anything by being overly cautious.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-04 Thread STINNER Victor

STINNER Victor  added the comment:

+if (sigemptyset() || sigfillset()) {

I'm not sure that sigemptyset() is needed.

sigfillset() manual page:

   sigfillset() initializes set to full, including all signals.

The function is used to *initialize* a set.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-04 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

This is expected, see issue33329.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-04 Thread Cheryl Sabella

Cheryl Sabella  added the comment:

On Ubuntu 14.04, I get the same results as Victor.

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-04 Thread STINNER Victor

STINNER Victor  added the comment:

FYI on Fedora 27, I get:

>>> signal.NSIG
65
>>> set(range(0, signal.NSIG)) - signal.valid_signals()
{0, 33, 32}
>>> len(signal.valid_signals())
62
>>> min(signal.valid_signals())

>>> max(signal.valid_signals())


So signals 0, 32 and 33 are invalid, the first valid signal is 1 and the last 
is 64.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-04 Thread Antoine Pitrou

Change by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-04 Thread Antoine Pitrou

Antoine Pitrou  added the comment:


New changeset 9d3627e311211a1b4abcda29c36fe4afe2c46532 by Antoine Pitrou in 
branch 'master':
bpo-2: Add signal.valid_signals() (GH-6581)
https://github.com/python/cpython/commit/9d3627e311211a1b4abcda29c36fe4afe2c46532


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33332] Expose valid signal set (sigfillset()): add signal.valid_signals()

2018-05-03 Thread STINNER Victor

Change by STINNER Victor :


--
title: Expose valid signal set (sigfillset()) -> Expose valid signal set 
(sigfillset()): add signal.valid_signals()

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com