[issue33435] incorrect detection of information of some distributions

[Petr Viktorin]

Petr Viktorin  added the comment:

linux_distribution has beed deprecated for a while and has been removed in 
GH-6871 (bpo-28167)

See https://pypi.org/project/distro for distro detection.

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Petr Viktorin]

Petr Viktorin  added the comment:

I understand that's what distro (https://github.com/nir0s/distro) is based on 
-- but a lot of complexity is required on top of that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Andrey Bychkov]

Andrey Bychkov  added the comment:

I think, at this moment, the optimal is parsing information from os-release 
file, because it's contained in majority linux distributions. Also can using 
'Lsb_release -a' command, but not all distributions support 'Linux Standard 
Base'. At final can using at first parsing the os-release and if it failed, can 
using the lsb command parse.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Petr Viktorin]

Petr Viktorin  added the comment:

Python's deprecation process takes several years, but linux_distribution is 
actually nearing the end of it. It is planned to be removed.

Your improvement is great, but at this point, it is more similar to adding a 
new feature to the standard library, than fixing a bug.

What are the use cases for linux_distribution()? Does it solve a common enough 
(and clear enough) problem that it should be in the stdlib?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Andrey Bychkov]

Andrey Bychkov  added the comment:

I think that it would be good to update linux_distribution, the discussion has 
been going on for a long time, but still in some cases the information is not 
determined correctly.
It seems to me that the methods used are not entirely correct. My change more 
accurately determines information about the distribution using the modern 
standard-file os-release.
If my change seems to be good, I can continue to edit linux_distribution.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Petr Viktorin]

Petr Viktorin  added the comment:

Oh, and there's a long discussion on the deprecation here: 
https://bugs.python.org/issue1322

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Petr Viktorin]

Petr Viktorin  added the comment:

linux_distribution is deprecated since 3.5, so I don't think it makes sense to 
modify it.
(see 
https://docs.python.org/3/library/platform.html#platform.linux_distribution)

Can you use a third-party package instead, e.g. distro?
http://distro.readthedocs.io/en/latest/

--
nosy: +petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Andrey Bychkov]

Andrey Bychkov  added the comment:

it's patch is not actual. new diff in git pull request!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +6411

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +6410
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33435] incorrect detection of information of some distributions

[Andrey Bychkov]

New submission from Andrey Bychkov :

In some linux distributions, the information about the distribution is 
incorrectly determined when the linux_distribution() method is called from the 
platform class. Since the information file os-release becomes a certain 
standard, I propose first of all to check its availability and if it is in the 
system, then parse the information from it. I apply the patch. It will work 
well with version 2.7.

--
components: Library (Lib)
files: fixed_lib_platform_os-release.patch
keywords: patch
messages: 316232
nosy: Andrey Bychkov
priority: normal
severity: normal
status: open
title: incorrect detection of information of some distributions
type: behavior
versions: Python 3.6
Added file: 
https://bugs.python.org/file47572/fixed_lib_platform_os-release.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com