[issue33536] dataclasses.make_dataclass does not validate fields for being valid identifiers

Change by Eric V. Smith : -- priority: release blocker -> resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33536] dataclasses.make_dataclass does not validate fields for being valid identifiers

miss-islington added the comment: New changeset 6409e759df0654f4a081eb4a50aadde995382043 by Miss Islington (bot) in branch '3.7': bpo-33536: Validate make_dataclass() field names. (GH-6906)

[issue33536] dataclasses.make_dataclass does not validate fields for being valid identifiers

Change by miss-islington : -- pull_requests: +6576 ___ Python tracker ___

[issue33536] dataclasses.make_dataclass does not validate fields for being valid identifiers

Eric V. Smith added the comment: New changeset 4e81296b1874829912c687eba4d39361ab51e145 by Eric V. Smith in branch 'master': bpo-33536: Validate make_dataclass() field names. (GH-6906) https://github.com/python/cpython/commit/4e81296b1874829912c687eba4d39361ab51e145

[issue33536] dataclasses.make_dataclass does not validate fields for being valid identifiers

Change by Eric V. Smith : -- keywords: +patch pull_requests: +6574 stage: -> patch review ___ Python tracker ___

[issue33536] dataclasses.make_dataclass does not validate fields for being valid identifiers

New submission from Eric V. Smith : I'm going to make this a release blocker, since it's basically a code injection vector, although I know of no way to exploit it. The fix is easy enough. -- nosy: +ned.deily priority: high -> release blocker

[issue33536] dataclasses.make_dataclass does not validate fields for being valid identifiers

Change by Eric V. Smith : -- assignee: eric.smith nosy: eric.smith priority: high severity: normal status: open title: dataclasses.make_dataclass does not validate fields for being valid identifiers type: behavior versions: Python 3.7, Python 3.8