[issue33554] Optimize PyDictObject

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I'm -1 too. There are no visible benefits, but this change makes maintaining 
harder and adds a risk of introducing bugs and performance regression.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[INADA Naoki]

INADA Naoki  added the comment:

> A little performance optimization, but I think the key is not in
performance optimization.
> The semantics of the dictresize function are not uniform, and it is
inconvenient for others to read. The dictresize function should be split to
make it just resize. What do you think?

I can't understand.
What dictresize does now other than resize?
Could you show how dictresize can be simplified when clear_dummy_keys() is
added?

Anyway, current my opinion is -1 on this.
We can add similar function when fixing Issue31954.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[b@n]

b@n  added the comment:

A little performance optimization, but I think the key is not in performance 
optimization.
The semantics of the dictresize function are not uniform, and it is 
inconvenient for others to read. The dictresize function should be split to 
make it just resize. What do you think?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Ah, I didn't notice that this affects only dicts with shared keys! Well, this 
is not related to the issue with OrderedDict which can't have shared keys.

Still we need evidences of the performance benefit. The PR adds >40 lines of 
code and the benefit should be large enough to compensate the maintaining 
complexity and possible performance regressions in other parts of the code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[b@n]

b@n  added the comment:

Will not break OrderedDict, The order is still the same.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Are you aware of causes that prevented writing the code in this way? This will 
break OrderedDict. Issue31954 is an attempt to solve this problem (and it 
supersedes this issue).

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[INADA Naoki]

INADA Naoki  added the comment:

Could you show some micro benchmark shows performance benefit?

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +6602
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33554] Optimize PyDictObject

[b@n]

New submission from b@n :

make_keys_shared reusing oldkeys memory

--
components: Interpreter Core
messages: 316901
nosy: b@n
priority: normal
severity: normal
status: open
title: Optimize PyDictObject
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com