[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

It's nice to see this issue fixed :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Change by Eric Snow :


--
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

I've re-enabled the subinterpreter tests, but left the one problem test 
(ChannelTests.test_run_string_arg_resolved) disabled.  I also changed all uses 
of %lld to use PRId64 instead.  (Thanks, Victor, for the suggestion.)

The buildbots look good.  I'll keep an eye on "x86 Gentoo Refleaks 3.x" for the 
next time it runs (starts every 24 hours; 10 hours from now).  When that passes 
I'll close this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:


New changeset ab4a1988fd4347484a7928394b94e2cdf5f8f2a7 by Eric Snow in branch 
'master':
bpo-33615: Re-enable subinterpreter tests. (#7552)
https://github.com/python/cpython/commit/ab4a1988fd4347484a7928394b94e2cdf5f8f2a7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Change by Eric Snow :


--
pull_requests: +7184

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

Yeah, I did a custom build the other day.  Sorry about the delay in disabling 
the test again and thanks for getting it done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:


New changeset c4f3cb772bc2d93d91ee1750eed817262f3ed57d by Victor Stinner in 
branch 'master':
bpo-33615: Skip test__xxsubinterpreters (GH-7503)
https://github.com/python/cpython/commit/c4f3cb772bc2d93d91ee1750eed817262f3ed57d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

test__xxsubinterpreters prevents to get results from Gentoo Refleaks 3.x and 
Windows Refleaks 3.x, it also broke multiple CIs and it introduced random 
failures. For all these reasons, I skipped the test. See the general policy for 
CIs:
https://mail.python.org/pipermail/python-dev/2018-May/153753.html

Eric: if you need CIs to check if a change fix test__xxsubinterpreters, they 
are ways to trigger custom builds, but I don't recall how to do that :-D You 
should be able to do that on buildbots at least, the devguide explains how to 
do it, or ask maybe Zachary Ware. Until the crash is fixed, I would prefer to 
leave the test skipped.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +7131
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Same error in AMD64 Windows10 3.x:

http://buildbot.python.org/all/#/builders/3/builds/941

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

FTR, bpo-33724 is related

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

This appears to be recurring on the "x86 Gentoo Refleaks 3.x" builder still.  I 
was thrown off by the success of the first run after I landed my fix:

http://buildbot.python.org/all/#/builders/1/builds/241

FYI, the other buildbots having this issue before (e.g. "ARMv7 Ubuntu 3.x") are 
still passing.

--
resolution: fixed -> 
stage: resolved -> needs patch
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Change by Eric Snow :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:


New changeset 63799136e6c0491bb5d6f4a234d5a775db3458db by Eric Snow in branch 
'master':
bpo-33615: Re-enable a subinterpreter test. (gh-7251)
https://github.com/python/cpython/commit/63799136e6c0491bb5d6f4a234d5a775db3458db


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

FYI, I plan on closing this issue only *after* I've re-enabled the crashing 
test and it passes. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

Now the test runs but doesn't crash anymore: bpo-33724.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:


New changeset 110bc01407ac8c75545d0386577c6e17254d97d9 by Eric Snow in branch 
'master':
bpo-33615: Temporarily disable a test that is triggering crashes on a few 
buildbots. (gh-7288)
https://github.com/python/cpython/commit/110bc01407ac8c75545d0386577c6e17254d97d9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Change by Eric Snow :


--
pull_requests: +6914

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Change by Eric Snow :


--
keywords: +patch
pull_requests: +6876
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Buildbot AMD64 FreeBSD 10.x Shared 3.x is failing with the same problem:

Assertion failed: (_PyGCHead_REFS(gc) != 0), function visit_decref, file 
Modules/gcmodule.c, line 277.
Fatal Python error: Aborted

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

I haven't been able to reproduce the issue thus far.  From the assert in the 
buildbot logs, it's clear that I've decref'ed an object one too many times.  
Given the relevant PR, it's probably something I changed in the channel 
implementation.  It could also be something that wasn't triggered until the 
tests added in the PR.

Any thoughts on what might be common to the 3 failing buildbots, such that 
they're the only ones to hit the assert?

* x86 Gentoo Refleaks 3.x
* ARMv7 Ubuntu 3.x
* PPC64 AIX 3.x

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

Any progress on this issue? It's still crashing the ARMv7 Ubuntu 3.x buildbot.

Eric: are you able to reproduce the issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

no worries :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

Oh, I didn't know that it was a 3.8-only issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

Correct.  These failures are only on master.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Ned Deily]

Ned Deily  added the comment:

Victor:

>It would be nice to fix this bug before Python 3.7.0 final: either skip the 
>test, or fix it.

These tests (and failures) are only on master / 3.x, not 3.7, right?  If so, 
they have no bearing on 3.7.0.

--
nosy: +ned.deily
priority: deferred blocker -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

It would be nice to fix this bug before Python 3.7.0 final: either skip the 
test, or fix it.

Since the functions are still private, skipping a single test (until it's 
fixed) should be fine.

--
priority: normal -> deferred blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

There are a couple of other buildbots with the same failure:

ARMv7 Ubuntu 3.x:  http://buildbot.python.org/all/#/builders/106/builds/1066
PPC64 AIX 3.x:  http://buildbot.python.org/all/#/builders/10/builds/1005

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

FTR, this started happening after the following commit:

commit 6d2cd9036c0ab78a83de43d1511befb7a7fc0ade
Author: Eric Snow 
Date:   Wed May 16 15:04:57 2018 -0400

bpo-32604: Improve subinterpreter tests. (#6914)

Add more tests for subinterpreters. This patch also fixes a few small 
defects in the channel implementation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[Eric Snow]

Eric Snow  added the comment:

I'll take a look.  Thanks!

--
assignee:  -> eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33615] test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x

[STINNER Victor]

New submission from STINNER Victor :

http://buildbot.python.org/all/#/builders/1/builds/232

(...)
3:28:16 load avg: 3.67 [401/416/3] test__xxsubinterpreters crashed (Exit code 
-6) -- running: test_asyncio (4631 sec)
python: Modules/gcmodule.c:277: visit_decref: Assertion `_PyGCHead_REFS(gc) != 
0' failed.
Fatal Python error: Aborted

Current thread 0xb748a700 (most recent call first):
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/case.py", 
line 615 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/case.py", 
line 663 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/support/__init__.py",
 line 1781 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/support/__init__.py",
 line 1882 in _run_suite
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/support/__init__.py",
 line 1972 in run_unittest
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/runtest.py",
 line 175 in test_runner
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/runtest.py",
 line 176 in runtest_inner
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/runtest.py",
 line 140 in runtest
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/runtest_mp.py",
 line 67 in run_tests_slave
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/main.py",
 line 517 in _main
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/main.py",
 line 510 in main
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/main.py",
 line 585 in main
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/regrtest.py", 
line 46 in _main
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/regrtest.py", 
line 50 in 
  File "/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/runpy.py", 
line 85 in _run_code
  File "/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/runpy.py", 
line 193 in _run_module_as_main
(...)
Re-running test 'test__xxsubinterpreters' in verbose mode
(...)
test_recv_not_found (test.test__xxsubinterpreters.ChannelTests) ... ok
test_run_string_arg_resolved (test.test__xxsubinterpreters.ChannelTests) ... 
python: Modules/gcmodule.c:277: visit_decref: Assertion `_PyGCHead_REFS(gc) != 
0' failed.
Fatal Python error: Aborted
Current thread 0xb74b9700 (most recent call first):
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/case.py", 
line 615 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/case.py", 
line 663 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/unittest/runner.py", 
line 176 in run
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/support/__init__.py",
 line 1882 in _run_suite
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/support/__init__.py",
 line 1972 in run_unittest
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/runtest.py",
 line 175 in test_runner
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/runtest.py",
 line 176 in runtest_inner
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/runtest.py",
 line 140 in runtest
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.refleak/build/Lib/test/libregrtest/main.py",
 line 291 in rerun_failed_tests
  File