[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[STINNER Victor]

STINNER Victor  added the comment:

I was waiting for the encoding fix to close this issue, but bpo-34604 has been 
created.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[STINNER Victor]

STINNER Victor  added the comment:

It has been decided to not touch pwd.getpwall() nor grp.getgrall(): 
https://github.com/python/cpython/pull/7081

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 23e65b25557f957af840cf8fe68e80659ce28629 by Victor Stinner 
(William Grzybowski) in branch 'master':
bpo-33625: Release GIL for grp.getgr{nam,gid} and pwd.getpw{nam,uid} (GH-7081)
https://github.com/python/cpython/commit/23e65b25557f957af840cf8fe68e80659ce28629


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[STINNER Victor]

STINNER Victor  added the comment:

More data to decide if the change should be backported or not: bpo-32186 
(Release the GIL during lseek and fstat) has been backported to Python 2.7, but 
then cffi started to crash:
https://bugzilla.redhat.com/show_bug.cgi?id=1561170#c28

At the end, it's a bug in cffi, there was a race condition in cffi. But still, 
the backport *indirectly* caused a crash.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[Ned Deily]

Ned Deily  added the comment:

> For a recent example of change releasing the GIL, see bpo-32186 which has 
> been backported up to 2.7.

Playing Devil's Advocate here: yes, but that was a far simpler and less 
extensive change.  bpo-32186 did not change configure.ac and pyconfig.h.in and 
I suspect that the impact of the old behavior that bpo-32186 was far more wide 
spread than that of bpo-33625 (stating files on a NFS file system versus doing 
getpwnam/getpwuid's).  Also when Christian made his comment about a bug fix, 
the proposed PR was much simpler in scope.

I am not saying that we definitely should not backport to 3.7 but I don't think 
it is an automatic call as the PR now stands.  In any case, we should first get 
the fix into master and get some exposure there before deciding whether to 
backport.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[STINNER Victor]

STINNER Victor  added the comment:

For a recent example of change releasing the GIL, see bpo-32186 which has been 
backported up to 2.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I think this change is too large for bugfix. It is a performance enhancement, 
but doing it right needs non-trivial rewriting of the code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[Ned Deily]

Ned Deily  added the comment:

With the updated PR that uses reentrant system functions if available, this now 
seems like a pretty big change to be adding to older maintenance releases, 
especially since it seems like it would be primarily a performance enhancement 
and not fixing a "repeatable" bug.  I don't think we should backport this to 
3.6 or 2.7.  If we can get it in prior to 3.7.0rc1, I'd be kinda OK with 
backporting to 3.7.  Sound OK?

--
nosy: +ned.deily
versions:  -Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:

In the future please use gender-neutral words such as "everyone", "people", or
"folks" instead of "guys". Thanks.

--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

[William Grzybowski]

William Grzybowski  added the comment:

I have updated the PR to used the re-entrant versions.

Let me know what you guys think. Thanks!

--
title: Disable GIL on getpwnam and getpwuid -> Release GIL for 
grp.getgr{nam,gid} and pwd.getpw{nam,uid}

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com