[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -14161 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13660 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -15156 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -10267 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13654 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

miss-islington added the comment: New changeset b50edac42fd39d58ba51eb9cee2d3645a2e28ca4 by Miss Islington (bot) in branch '3.8': bpo-33694: Remove test_asyncio ProactorDatagramTransportTests (GH-16288) https://github.com/python/cpython/commit/b50edac42fd39d58ba51eb9cee2d3645a2e28ca4

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13642 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13676 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13663 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13643 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13656 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13627 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13661 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13625 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13649 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -14111 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -12891 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13220 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by miss-islington : -- pull_requests: +15891 pull_request: https://github.com/python/cpython/pull/16305 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: New changeset bc2256ea177a653bcab15b06b5f5725b10c1fff3 by Victor Stinner in branch 'master': bpo-33694: Remove test_asyncio ProactorDatagramTransportTests (GH-16288) https://github.com/python/cpython/commit/bc2256ea177a653bcab15b06b5f5725b10c1fff3

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: +15873 pull_request: https://github.com/python/cpython/pull/16288 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Srinivas Nyayapati : -- pull_requests: +15156 pull_request: https://github.com/python/cpython/pull/15170 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: +14161 pull_request: https://github.com/python/cpython/pull/14336 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Zackery Spytz : -- pull_requests: +14111 pull_request: https://github.com/python/cpython/pull/14152 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Pablo Galindo Salgado : -- nosy: -pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Andrew Svetlov : -- nosy: -asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Inada Naoki : -- pull_requests: +13676 pull_request: https://github.com/python/cpython/pull/13787 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Inada Naoki : -- pull_requests: +13663 pull_request: https://github.com/python/cpython/pull/13775 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Inada Naoki : -- pull_requests: +13661 pull_request: https://github.com/python/cpython/pull/12884 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Ned Deily : -- pull_requests: +13660 pull_request: https://github.com/python/cpython/pull/13773 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Pablo Galindo Salgado : -- pull_requests: +13656 pull_request: https://github.com/python/cpython/pull/13760 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Yury Selivanov : -- nosy: -yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Raymond Hettinger : -- pull_requests: +13654 pull_request: https://github.com/python/cpython/pull/13769 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Petr Viktorin : -- pull_requests: +13649 pull_request: https://github.com/python/cpython/pull/13761 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Karthikeyan Singaravelan : -- pull_requests: +13643 pull_request: https://github.com/python/cpython/pull/13745 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Andrew Svetlov : -- pull_requests: +13642 pull_request: https://github.com/python/cpython/pull/13754 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Tim Hoffmann : -- pull_requests: +13627 pull_request: https://github.com/python/cpython/pull/8518 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Andrew Svetlov : -- pull_requests: +13625 pull_request: https://github.com/python/cpython/pull/13630 ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Nicolai Moore : -- pull_requests: +13220 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -13206 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: +13206 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: +12891 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: +10267 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: -9681 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Martin Bijl-Schwab : -- pull_requests: +9681 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: New changeset 142e3c08a40c75b5788474b0defe7d5c0671f675 by Victor Stinner in branch '3.6': [3.6] bpo-32356: idempotent pause_/resume_reading (GH-4914) (GH-7629) https://github.com/python/cpython/commit/142e3c08a40c75b5788474b0defe7d5c0671f675 --

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: "Since it a minor change we can reconsider it as s bug fix. Feel free to make a pr." Ok, I created https://github.com/python/cpython/pull/7629/ for bpo-32356 -- ___ Python tracker

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Yury Selivanov added the comment: Since it a minor change we can reconsider it as s bug fix. Feel free to make a pr. -- ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: > pause_reading and resume_reading became idempotent only in 3.7 Do you consider that it's a new feature or a bugfix? Should we backport this change to 3.6? Currently, race.py fails with an error because of the 3.6 behaviour. (I modified asyncio to be able

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Yury Selivanov added the comment: pause_reading and resume_reading became idempotent only in 3.7 -- ___ Python tracker ___ ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: I ran attached race.py on the 3.6 branch: * 2000 packets of 16 KiB: ok * 50 packets of 16 MiB: ok It seems like Python 3.6 (at least the 3.6 development branch) doesn't have this bug. It didn't see the bug recently, so I close the issue. Python 3.6 has a

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

miss-islington added the comment: New changeset 17beebcc8b22a66b7973cbe5b1577567ab391c0a by Miss Islington (bot) in branch '3.7': bpo-33694: Fix typo in helper function name (GH-7522) https://github.com/python/cpython/commit/17beebcc8b22a66b7973cbe5b1577567ab391c0a -- nosy:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by miss-islington : -- pull_requests: +7151 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: New changeset ff6c07729211fb98431a2793e074d07a21e0650a by Victor Stinner in branch 'master': bpo-33694: Fix typo in helper function name (GH-7522) https://github.com/python/cpython/commit/ff6c07729211fb98431a2793e074d07a21e0650a --

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: +7150 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: I fixed the root issue, a race condition in ProactorEventLoop. But I prefer to keep the issue open a few days to see if the bug is really gone from all CIs. -- ___ Python tracker

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: New changeset 8fa398d5cecec80990c5642b081f52cbbc6a05eb by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-33694: Fix race condition in asyncio proactor (GH-7498) (GH-7499)

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by miss-islington : -- pull_requests: +7124 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: New changeset 79790bc35fe722a49977b52647f9b5fe1deda2b7 by Victor Stinner in branch 'master': bpo-33694: Fix race condition in asyncio proactor (GH-7498) https://github.com/python/cpython/commit/79790bc35fe722a49977b52647f9b5fe1deda2b7 --

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- pull_requests: +7123 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by Yury Selivanov : -- pull_requests: +7111 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Change by STINNER Victor : -- keywords: +patch pull_requests: +7106 stage: -> patch review ___ Python tracker ___ ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: race.py: simple echo client and server sending packets in both directions. Pause/resume reading the client transport every 100 ms to trigger the bug. Using ProactorEventLoop and 2000 packets of 16 KiB, I easily reproduce the bug. So again, it's nothing

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: Yury, Andrew, Ned: I set the priority to release blocker because I'm scared by what I saw. The START TLS has a race condition in its ProactorEventLoop implementation. But the bug doesn't see to be specific to START TLS, but rather to

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: Something else. The bug occurs when CancelIoEx() (on the current overlapped WSARecv()) fails internally with ERROR_NOT_FOUND. According to overlapped.c, it means: /* CancelIoEx returns ERROR_NOT_FOUND if the I/O completed in-between */

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: _ProactorReadPipeTransport.set_transport(): if self.is_reading(): # reset reading callback / buffers / self._read_fut self.pause_reading() self.resume_reading() This method cancelled the pending overlapped

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: Sorry, the patch to reproduce the issue on Linux is wrong: it introduces a bug in the test. Ignore this comment. -- It seems like I found the root cause: pause_reading() / resume_reading() on the transport is not safe. Sometimes, we loose data. See the

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: The issue occurs when the server calls start_tls() because the client calls start_tls(). In that case, ServerProto.data_received() is called with the server TLS handshake and so the client SSLProtocol never this this handshake from server... --

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: Call stack when the asyncio client connects to the server when the bug occurs: SSLProtocol.connection_made() -> SSLProtocol._start_handshake() -> SSLProtocol._process_write_backlog() -> SSLPipe.do_handshake() -> SSLPipe.feed_ssldata(b'', only_handshake=True)

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: The bug can be reproduced on Linux using this patch: diff --git a/Lib/test/test_asyncio/test_sslproto.py b/Lib/test/test_asyncio/test_sslproto.py index 78ab1eb822..735313152c 100644 --- a/Lib/test/test_asyncio/test_sslproto.py +++

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: Another variant seen on AppVeyor (PR 7439, master branch): https://ci.appveyor.com/project/python/cpython/build/3.8build16980 == ERROR: test_create_connection_ssl_failed_certificate

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: > AMD64 Windows8.1 Non-Debug 3.x > ERROR: test_create_connection_ssl_failed_certificate > (test.test_asyncio.test_sslproto.ProactorStartTLSTests) Not surprising: same error on AMD64 Windows8.1 Non-Debug 3.7:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: A variant of the bug? AMD64 Windows8.1 Non-Debug 3.x: http://buildbot.python.org/all/#/builders/12/builds/948 == ERROR: test_create_connection_ssl_failed_certificate

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Pablo Galindo Salgado added the comment: The test fails also on x86 Windows7 3.x: http://buildbot.python.org/all/#/builders/58/builds/947 -- nosy: +pablogsal ___ Python tracker

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: The test also failed on AMD64 Windows8.1 Refleaks 3.7. This buildbot is also very slow because it runs reference leak hunting. It confirms that the remaining issue is a race condition which is only seen when the system becomes slow.

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: > I used SNDBUF to enforce send buffer overloading. What is that? Would you mind to elaborate? I'm curious :-) -- ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Yury Selivanov added the comment: > We can remove the socket buffers size manipulation at all without any problem. When I tried to do that I think I was having more failures with that test. But really up to you. -- ___ Python tracker

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Andrew Svetlov added the comment: I used SNDBUF to enforce send buffer overloading. It is not required by sendfile tests but I thought that better to have non-mocked way to test such situations. We can remove the socket buffers size manipulation at all without any problem. --

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

Yury Selivanov added the comment: I can't reproduce test_start_tls_server_1 fails when I do (screenshot attached) 1. run test_asyncio 2. run test_asyncio.test_sslproto 3. run test_asyncio.test_sslproto -m test_start_tls_server_1 I run them in Windows 7 VM on Mac OS. All other tests pass

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

STINNER Victor added the comment: The test fails also on x86 Windows7 3.7: http://buildbot.python.org/all/#/builders/111/builds/297 -- ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

New submission from STINNER Victor : test_asyncio.test_start_tls_server_1() got many fixes recently: see bpo-32458 and bpo-33674... but it still fails on Python on x86 Windows7 3.x at revision bb9474f1fb2fc7c7ed9f826b78262d6a12b5f9e8 which contains all these fixes. The test fails even when