[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[miss-islington]

miss-islington  added the comment:


New changeset 663836e1179ea79eac12e55670af7e89a531a060 by Miss Islington (bot) 
in branch '3.8':
[3.8] bpo-34003: Re-add versionchanged entry in csv docs (GH-20657) (GH-20771)
https://github.com/python/cpython/commit/663836e1179ea79eac12e55670af7e89a531a060


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[miss-islington]

miss-islington  added the comment:


New changeset 73b728a779aa7d6d8f088c4b21447bba4bf3a351 by Miss Islington (bot) 
in branch '3.9':
[3.9] bpo-34003: Re-add versionchanged entry in csv docs (GH-20657) (GH-20770)
https://github.com/python/cpython/commit/73b728a779aa7d6d8f088c4b21447bba4bf3a351


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[miss-islington]

Change by miss-islington :


--
pull_requests: +19969
pull_request: https://github.com/python/cpython/pull/20771

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[miss-islington]

Change by miss-islington :


--
pull_requests: +19968
pull_request: https://github.com/python/cpython/pull/20770

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[miss-islington]

miss-islington  added the comment:


New changeset 7aed0524d4129766a6032326949ef7f91f6f6dfc by Éric Araujo in branch 
'master':
bpo-34003: Re-add versionchanged entry in csv docs (GH-20657)
https://github.com/python/cpython/commit/7aed0524d4129766a6032326949ef7f91f6f6dfc


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Éric Araujo]

Change by Éric Araujo :


--
nosy: +eric.araujo
nosy_count: 3.0 -> 4.0
pull_requests: +19876
pull_request: https://github.com/python/cpython/pull/20657

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Raymond Hettinger]

Change by Raymond Hettinger :


--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Raymond Hettinger]

Change by Raymond Hettinger :


--
resolution: not a bug -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Raymond Hettinger]

Raymond Hettinger  added the comment:


New changeset 9f3f0931cfc58498086d287226650599a97412bb by Raymond Hettinger 
(Michael Selik) in branch 'master':
bpo-34003: Use dict instead of OrderedDict in csv.DictReader (GH-8014)
https://github.com/python/cpython/commit/9f3f0931cfc58498086d287226650599a97412bb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Raymond Hettinger]

Raymond Hettinger  added the comment:

This might need a deprecation before switching but it would be useful.  The 
DictReader can produced huge numbers of instances that would benefit from the 
smaller size.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Michael Selik]

Michael Selik  added the comment:

I searched for previously submitted issues, but somehow didn't spot #32339.

I'll do some searching for whether anyone uses ``move_to_end`` on DictReader 
rows and respond to the mailing list with a report.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Eric V. Smith]

Eric V. Smith  added the comment:

The dict and OrderedDict APIs are slightly different, although I'm not sure 
anyone cares. See #32339. In that PR 
https://github.com/python/cpython/pull/4904, Guido said to not make this 
change. See also the python-dev discussion at 
https://mail.python.org/pipermail/python-dev/2017-December/151351.html

If you feel strongly about this, I suggest discussing it on python-dev first.

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Michael Selik]

Change by Michael Selik :


--
components: +Library (Lib)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Michael Selik]

Change by Michael Selik :


--
type:  -> performance

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Michael Selik]

Michael Selik  added the comment:

Pull request.

https://github.com/python/cpython/pull/8014

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Michael Selik]

Change by Michael Selik :


--
keywords: +patch
pull_requests: +7622
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34003] csv.DictReader can return basic dict instead of OrderedDict

[Michael Selik]

New submission from Michael Selik :

Since dicts are now keeping insertion order as of 3.7, we can switch to the 
more efficient construction of dict rather than OrderedDict for each row in the 
CSV file.

--
messages: 320734
nosy: selik
priority: normal
severity: normal
status: open
title: csv.DictReader can return basic dict instead of OrderedDict
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com