[issue34239] Convert test_bz2 to use tempfile

Change by Tim Golden : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue34239] Convert test_bz2 to use tempfile

TJG added the comment: Thanks, Brett. I'll address Serhiy's comment with a new PR and then tidy yup. -- nosy: +tjguk ___ Python tracker ___

[issue34239] Convert test_bz2 to use tempfile

Brett Cannon added the comment: Should this issue be closed, Tim, after you update for Serhiy's suggestion? (Basically I'm just making sure you know issues are not automatically closed after merge :) . -- nosy: +brett.cannon ___ Python tracker

[issue34239] Convert test_bz2 to use tempfile

Serhiy Storchaka added the comment: It is more reliable to use test.support.unlink(). -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue34239] Convert test_bz2 to use tempfile

Tim Golden added the comment: New changeset 6a62e1d365934de82ff7c634981b3fbf218b4d5f by Tim Golden in branch 'master': bpo-34239: Convert test_bz2 to use tempfile (#8485) https://github.com/python/cpython/commit/6a62e1d365934de82ff7c634981b3fbf218b4d5f --

[issue34239] Convert test_bz2 to use tempfile

Change by Tim Golden : -- keywords: +patch pull_requests: +8007 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34239] Convert test_bz2 to use tempfile

New submission from Tim Golden : test_bz2 currently uses the test.support.TESTFN functionality which creates a temporary file local to the test directory named around the pid. This can give rise to race conditions where tests are competing with each other to delete and recreate the file.