[issue34294] re.finditer and lookahead bug

Ma Lin added the comment: Serhiy Storchaka lost his sight. Please stop any work and rest, because your left eye will have more burden, and your mental burden will make it worse. Go to hospital ASAP. If any other core developer want to review this patch, I would like to give a detailed

[issue34294] re.finditer and lookahead bug

Ma Lin added the comment: I tried to fix it, feel free to create a new PR if you don't want this one. PR11546 has a small question, should `state->data_stack` be dealloced as well? FYI, function `state_reset(SRE_STATE* state)` in file `_sre.c`:

[issue34294] re.finditer and lookahead bug

Change by Ma Lin : -- keywords: +patch, patch, patch pull_requests: +11162, 11163, 11164 stage: -> patch review ___ Python tracker ___

[issue34294] re.finditer and lookahead bug

Change by Ma Lin : -- keywords: +patch pull_requests: +11162 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34294] re.finditer and lookahead bug

Change by Ma Lin : -- keywords: +patch, patch pull_requests: +11162, 11163 stage: -> patch review ___ Python tracker ___ ___

[issue34294] re.finditer and lookahead bug

Ma Lin added the comment: Simplify the test-case, it seem the `state` is not reset properly. Python 3.6.8 (tags/v3.6.8:3c6b436a57, Dec 24 2018, 00:16:47) >>> import re >>> re.findall(r"(?=(<\w+>)(<\w+>)?)", "") [('', ''), ('', '')] Python 3.7.2 (tags/v3.7.2:9a3ffc0492, Dec 23 2018, 23:09:28)

[issue34294] re.finditer and lookahead bug

Ma Lin added the comment: This bug generates wrong results silently, so I suggest mark it as release blocker for 3.7.1 -- nosy: +Ma Lin ___ Python tracker ___

[issue34294] re.finditer and lookahead bug

Karthikeyan Singaravelan added the comment: ➜ cpython git:(70d56fb525) ✗ ./python.exe Python 3.7.0a2+ (tags/v3.7.0a2-341-g70d56fb525:70d56fb525, Jul 31 2018, 21:58:10) [Clang 7.0.2 (clang-700.1.81)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> ➜

[issue34294] re.finditer and lookahead bug

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34294] re.finditer and lookahead bug

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue34294] re.finditer and lookahead bug

New submission from beardypig : I am experiencing and issue with the following regex when using finditer. (?=<(?P\w+)/?>(?:(?P.+?))?)", " (I know it's not the best method of dealing with HTML, and this is a simplified version) For example: [m.groupdict() for m in