[issue34382] test_os.test_mode fails when directory base directory has g+s set

[Michael Felt]

Michael Felt  added the comment:

Closing this, and my PR, as issue34664 is a repeat and already merged.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34382] test_os.test_mode fails when directory base directory has g+s set

[Michael Felt]

Michael Felt  added the comment:

For now, backport only means, imho to 3.7 and maybe 3.6. More could be merrier 
- but the goal is to clear the buildbots for regression testing.

This one is quite simple - so adding 2.7 to the list of backports would be 
great.

--
versions: +Python 2.7, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34382] test_os.test_mode fails when directory base directory has g+s set

[Michael Felt]

Michael Felt  added the comment:

Likewise, I have no idea who should review, or whether python2 should be 
included or not. 

The issue is not a bug in python, rather a shortcoming in the test suite. 

In short, since I do my builds in an environment where the mode includes SGID  
on the directory i see this “false” fail. 

Sent from my iPhone

> On 17 Aug 2018, at 23:19, Terry J. Reedy  wrote:
> 
> 
> Terry J. Reedy  added the comment:
> 
> 'Backport' might or might not mean 2.7. You should be able to explicitly 
> select versions in the box above.  I have no idea who should review this.
> 
> --
> nosy: +terry.reedy
> 
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34382] test_os.test_mode fails when directory base directory has g+s set

[Terry J. Reedy]

Terry J. Reedy  added the comment:

'Backport' might or might not mean 2.7. You should be able to explicitly select 
versions in the box above.  I have no idea who should review this.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34382] test_os.test_mode fails when directory base directory has g+s set

[Michael Felt]

Change by Michael Felt :


--
keywords: +patch
pull_requests: +8224
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34382] test_os.test_mode fails when directory base directory has g+s set

[Michael Felt]

New submission from Michael Felt :

test_mode assumes that the SGID bit is not set in the parent directory. If it 
is set the assertEqual() tests fail.

This PR checks the mode of 'base' to see if the SGID bit is set, or not, and 
compares results accordingly.

Back-porting requested.

--
components: Tests
messages: 323414
nosy: Michael.Felt
priority: normal
severity: normal
status: open
title: test_os.test_mode fails when directory base directory has g+s set
type: behavior
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com