[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution: rejected -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset ed21919d69ac22232cbc0dad0323477818112b6f by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.6':
bpo-34472: Add data descriptor signature to zipfile (GH-8871) (GH-9398)
https://github.com/python/cpython/commit/ed21919d69ac22232cbc0dad0323477818112b6f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 44989bc2696320cf55ae6f329aaf58edd49d792a by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.7':
bpo-34472: Add data descriptor signature to zipfile (GH-8871) (GH-9399)
https://github.com/python/cpython/commit/44989bc2696320cf55ae6f329aaf58edd49d792a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 6ec298114855b648a1f5fc4188ea3686a9d77fb3 by Serhiy Storchaka in 
branch '2.7':
[2.7] bpo-34472: Add data descriptor signature to zipfile (GH-8871) (ПР-9407)
https://github.com/python/cpython/commit/6ec298114855b648a1f5fc4188ea3686a9d77fb3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +8830

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you for your contribution Silas.

Since popular ZIP file implementation like Info-ZIP and Java write this 
signature unconditionally, I think most unzipping software support it if they 
support reading ZIP files in streaming mode at all, at it is safe to backport 
this change to all maintained versions.

--
type:  -> behavior
versions: +Python 2.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[miss-islington]

Change by miss-islington :


--
pull_requests: +8822

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[miss-islington]

Change by miss-islington :


--
pull_requests: +8821

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 4ba3b50bfe6d50cd82d208023ea23e203ab50589 by Serhiy Storchaka 
(Silas Sewell) in branch 'master':
bpo-34472: Add data descriptor signature to zipfile (GH-8871)
https://github.com/python/cpython/commit/4ba3b50bfe6d50cd82d208023ea23e203ab50589


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Silas Sewell]

Change by Silas Sewell :


--
keywords: +patch
pull_requests: +8348
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34472] zipfile: does not include optional descriptor signature

[Silas Sewell]

New submission from Silas Sewell :

When adding a fileobj that is not seekable to a zip using the zipfile module, 
the optional signature value 0x08074b50 is not included. This breaks certain 
zip implementations, including the builtin MacOS Archive Utility.

See https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT sections 
4.3.9.3 and 4.3.9.4

--
components: Library (Lib)
files: zip_stream_example.py
messages: 323943
nosy: silas
priority: normal
severity: normal
status: open
title: zipfile: does not include optional descriptor signature
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8
Added file: https://bugs.python.org/file47760/zip_stream_example.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com