[issue34679] asyncio.add_signal_handler call fails if not on main thread

miss-islington added the comment: New changeset cbf474c98e702d12c97cd16a1e44ede10ea52b5b by Miss Skeleton (bot) in branch '3.8': bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (GH-16901) https://github.com/python/cpython/commit/cbf474c98e702d12c97cd16a1e44ede10ea52b5b

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by miss-islington : -- pull_requests: +16439 pull_request: https://github.com/python/cpython/pull/16902 ___ Python tracker ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

STINNER Victor added the comment: New changeset 1b53a24fb4417c764dd5933bce505f5c94249ca6 by Victor Stinner in branch 'master': bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (GH-16901) https://github.com/python/cpython/commit/1b53a24fb4417c764dd5933bce505f5c94249ca6

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by STINNER Victor : -- pull_requests: +16437 pull_request: https://github.com/python/cpython/pull/16901 ___ Python tracker ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

miss-islington added the comment: New changeset 69d22b8fee442c12829a1032a72489c8133de271 by Miss Islington (bot) in branch '3.8': bpo-34679: Restore instantiation Windows IOCP event loop from non-main thread (GH-15492)

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by miss-islington : -- pull_requests: +15198 pull_request: https://github.com/python/cpython/pull/15512 ___ Python tracker ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Andrew Svetlov added the comment: New changeset 1c0600998681295735a18690fae184b0c9a4ca51 by Andrew Svetlov in branch 'master': bpo-34679: Restore instantiation Windows IOCP event loop from non-main thread (#15492)

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Kyle Stanley added the comment: > Kyle, thanks for the fix. > I have basically the same change in my PR but with test and news note. No problem, that works for me. I was mostly just trying to help with resolving some of the release blockers for 3.8b4. --

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by Andrew Svetlov : -- keywords: +patch pull_requests: +15180 pull_request: https://github.com/python/cpython/pull/15492 ___ Python tracker ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Andrew Svetlov added the comment: Kyle, thanks for the fix. I have basically the same change in my PR but with test and news note. -- ___ Python tracker ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Andrew Svetlov added the comment: The issue is related to Python 3.8 and master only. 3.6-3.7 are not affected -- versions: +Python 3.9 -Python 3.6, Python 3.7 ___ Python tracker

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by Kyle Stanley : -- keywords: +needs review -patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by Kyle Stanley : -- keywords: +patch pull_requests: +15163 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15477 ___ Python tracker ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Kyle Stanley added the comment: > How do we identify whether or not set_wakeup_fd() is being called from a > non-main thread? Never mind, I think I found the answer to my own question and tested a patch locally, I'll open a PR. -- ___ Python

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Kyle Stanley added the comment: > Skipping this call for non-main thread in proactor implementation makes sense. How do we identify whether or not set_wakeup_fd() is being called from a non-main thread? -- nosy: +aeros167 ___ Python tracker

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Brett Slatkin added the comment: Maybe we should just roll back https://bugs.python.org/issue34687 to fix both issues? Otherwise asyncio will be broken on Windows in 3.8. Is general API stability more important than performance? -- ___ Python

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Yury Selivanov added the comment: Andrew, can you fix ctrl-c/windows issue? I'm basically afk until monday. And we're not going to do anything about add_signal_handler in 3.8. -- ___ Python tracker

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Łukasz Langa added the comment: Please fix this ASAP, last 3.8 beta is scheduled for Monday. -- ___ Python tracker ___ ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by Łukasz Langa : -- nosy: +lukasz.langa, ned.deily priority: normal -> release blocker ___ Python tracker ___ ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Andrew Svetlov added the comment: Good point. For proactor event loop set_wakeup_fd() is used for Ctrl+C handling. Skipping this call for non-main thread in proactor implementation makes sense. -- assignee: -> asvetlov ___ Python tracker

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Brett Slatkin added the comment: I believe the scope of this bug may be larger than it originally seemed. Now that ProactorEventLoop is the default for Python 3.8 (https://bugs.python.org/issue34687), I'm seeing this same problem on Windows when you try to call asyncio.new_event_loop() from

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by Andrew Svetlov : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Andrew Svetlov added the comment: In my opinion, we should don't change the behavior. Signal handlers should be processed in main thread at the end, that's how Python works for regular synchronous API. Mentioning it in the doc makes sense. Would you make a pull request? --

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34679] asyncio.add_signal_handler call fails if not on main thread

Change by epiphyte : -- nosy: +epiphyte ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34679] asyncio.add_signal_handler call fails if not on main thread

New submission from Nic Watson : Summary: essentially asyncio.add_signal_handler doesn't work when called off the main thread. One might consider this a documentation failure. (Note: there's also a bigger issue with cleanup, which I'll submit separately) Exception in thread Thread-1: