[issue34728] deprecate *loop* argument for asyncio.sleep

Yury Selivanov added the comment: [victor] > Why does it not make sense to pass the loop to sleep? "it makes no sense > anymore" something changes? [andrew] `loop` argument passed to sleep should be always the same as returned from `get_running_loop()`. What Andrew said. Basically, it

[issue34728] deprecate *loop* argument for asyncio.sleep

Yury Selivanov added the comment: New changeset 9012a0fb4c4ec1afef9efb9fdb0964554ea17983 by Yury Selivanov in branch 'master': bpo-34728: Fix asyncio tests to run under "-Werror" (GH-9661) https://github.com/python/cpython/commit/9012a0fb4c4ec1afef9efb9fdb0964554ea17983 --

[issue34728] deprecate *loop* argument for asyncio.sleep

Andrew Svetlov added the comment: My understanding is: `loop` argument passed to sleep should be always the same as returned from `get_running_loop()`. Passing it explicitly can be considered as microoptimization but `get_running_loop()` is pretty fast now, no need for such micro-opts. On

[issue34728] deprecate *loop* argument for asyncio.sleep

STINNER Victor added the comment: FYI if I recall correctly, in the past, we preferred to pass explicitly the loop to avoid to have to get the current loop which may add an overhead. But the current trend is to get rid of the explicit loop parameter. > asyncio.sleep is a coroutine; passing

[issue34728] deprecate *loop* argument for asyncio.sleep

STINNER Victor added the comment: There is a new PR, so I change the issue resolution again. -- resolution: fixed -> ___ Python tracker ___

[issue34728] deprecate *loop* argument for asyncio.sleep

STINNER Victor added the comment: > Victor, you're looking at an outdated comment on this issue. No, I read the commit: https://github.com/python/cpython/commit/558c49bcf3a8543d64a68de836b5d855efd56696 warnings.warn("The loop argument is deprecated and scheduled for"

[issue34728] deprecate *loop* argument for asyncio.sleep

Change by Yury Selivanov : -- pull_requests: +9054 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34728] deprecate *loop* argument for asyncio.sleep

Yury Selivanov added the comment: > On python-committers, it has been said that 3.10 will follow Python 3.9, no? Victor, you're looking at an outdated comment on this issue. This is what's in the master branch:

[issue34728] deprecate *loop* argument for asyncio.sleep

Change by Serhiy Storchaka : -- stage: resolved -> needs patch status: closed -> open ___ Python tracker ___ ___ Python-bugs-list

[issue34728] deprecate *loop* argument for asyncio.sleep

STINNER Victor added the comment: > We should raise a DeprecationWarning in Python 3.8 and 3.9 and remove it in > 4.0. On python-committers, it has been said that 3.10 will follow Python 3.9, no? -- nosy: +vstinner ___ Python tracker

[issue34728] deprecate *loop* argument for asyncio.sleep

Serhiy Storchaka added the comment: Tests are failed when ran with -Werror. $ ./python -Werror -m test -vuall test_asyncgen ... == ERROR: test_async_gen_asyncio_01 (test.test_asyncgen.AsyncGenAsyncioTest)

[issue34728] deprecate *loop* argument for asyncio.sleep

Change by Carol Willing : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34728] deprecate *loop* argument for asyncio.sleep

Carol Willing added the comment: New changeset 558c49bcf3a8543d64a68de836b5d855efd56696 by Carol Willing (João Júnior) in branch 'master': bpo-34728: Remove deprecate *loop* argument in asyncio.sleep (GH-9415) https://github.com/python/cpython/commit/558c49bcf3a8543d64a68de836b5d855efd56696

[issue34728] deprecate *loop* argument for asyncio.sleep

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34728] deprecate *loop* argument for asyncio.sleep

Change by Felipe Rodrigues : -- nosy: +fbidu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34728] deprecate *loop* argument for asyncio.sleep

Change by Roundup Robot : -- keywords: +patch pull_requests: +8835 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34728] deprecate *loop* argument for asyncio.sleep

Yury Selivanov added the comment: Same for asyncio.wait and asyncio.wait_for. -- ___ Python tracker ___ ___ Python-bugs-list

[issue34728] deprecate *loop* argument for asyncio.sleep

New submission from Yury Selivanov : asyncio.sleep is a coroutine; passing a *loop* argument to it makes no sense anymore. We should raise a DeprecationWarning in Python 3.8 and 3.9 and remove it in 4.0. -- components: asyncio keywords: easy messages: 325684 nosy: asvetlov,