[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread Denis Ledoux 


Denis Ledoux  added the comment:

The pleasure is all mine.

Thanks to you and the other contributors involved. For my first contribution to 
Python, I am glad everything went smoothly :).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread STINNER Victor 


STINNER Victor  added the comment:

Thanks Denis Ledoux for your bug report and your fix!

It's nice to see this bug fixed in all branches ;-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset 6f97a50c86737458c6bed9970c8dc31a465eff22 by Victor Stinner (Denis 
Ledoux) in branch '2.7':
bpo-35017, socketserver: don't accept request after shutdown (GH-9952) 
(GH-10129)
https://github.com/python/cpython/commit/6f97a50c86737458c6bed9970c8dc31a465eff22


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread Denis Ledoux 


Change by Denis Ledoux :


--
pull_requests: +9461

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread miss-islington 


miss-islington  added the comment:


New changeset 8b1f52b5a93403acd7d112cd1c1bc716b31a418a by Miss Islington (bot) 
in branch '3.6':
bpo-35017, socketserver: don't accept request after shutdown (GH-9952)
https://github.com/python/cpython/commit/8b1f52b5a93403acd7d112cd1c1bc716b31a418a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread miss-islington 


miss-islington  added the comment:


New changeset 908082451382b8b3ba09ebba638db660edbf5d8e by Miss Islington (bot) 
in branch '3.7':
bpo-35017, socketserver: don't accept request after shutdown (GH-9952)
https://github.com/python/cpython/commit/908082451382b8b3ba09ebba638db660edbf5d8e


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9458

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9457

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-26 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset 10cb3760e8631a27f5db1e51b05494e29306c671 by Victor Stinner (Denis 
Ledoux) in branch 'master':
bpo-35017, socketserver: don't accept request after shutdown (GH-9952)
https://github.com/python/cpython/commit/10cb3760e8631a27f5db1e51b05494e29306c671


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-20 Thread Karthikeyan Singaravelan 


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-18 Thread Denis Ledoux 


Change by Denis Ledoux :


--
keywords: +patch
pull_requests: +9299
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-18 Thread Denis Ledoux 


New submission from Denis Ledoux :

After the shutdown of a `BaseServer`, the server may accept a last single 
request if it is sent between the server socket polling and the polling timeout.

This can be problematic for instance for a server restart for which you do not 
want to interrupt the service, by not closing the listening socket during the 
restart. One request can fail because of this behavior.

Note that only one request will fail, following requests will not be accepted, 
as expected.

--
components: Library (Lib)
messages: 327969
nosy: beledouxdenis
priority: normal
severity: normal
status: open
title: socketserver accept a last request after shutdown
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com