[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2020-01-20 Thread STINNER Victor 


STINNER Victor  added the comment:

This issue introduced a regression: bpo-39395 "The os module should unset() 
environment variable at exit".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-11-24 Thread Eddie Elizondo 


Eddie Elizondo  added the comment:

PR with fix is out.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-11-15 Thread Eddie Elizondo 


Eddie Elizondo  added the comment:

Woops! I'll get to it before the end of the weekend!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-11-14 Thread STINNER Victor 


STINNER Victor  added the comment:

This change introduced a reference leak: bpo-38803 "test_wait3 and test_wait4 
leaked references on x86 Gentoo Refleaks 3.x".

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-11-06 Thread Petr Viktorin 


Petr Viktorin  added the comment:

The module still uses tp_new directly, so it's not limited to only stable ABI, 
but that's for another issue.

Thanks for the contribution!

--
nosy: +petr.viktorin
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-11-05 Thread miss-islington 


miss-islington  added the comment:


New changeset b3966639d28313809774ca3859a347b9007be8d2 by Miss Islington (bot) 
(Eddie Elizondo) in branch 'master':
bpo-35381 Remove all static state from posixmodule (GH-15892)
https://github.com/python/cpython/commit/b3966639d28313809774ca3859a347b9007be8d2


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-09-11 Thread Eric Snow 


Eric Snow  added the comment:

@Jeroen, see Dino's expalantion in https://bugs.python.org/issue38075#msg351627 
(relative to the "random" module).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-09-10 Thread Eddie Elizondo 


Change by Eddie Elizondo :


--
pull_requests: +15533
pull_request: https://github.com/python/cpython/pull/15892

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-04-09 Thread Jeroen Demeyer 


Jeroen Demeyer  added the comment:

Just curious... how is PEP 384 relevant to modules insides CPython itself? I 
thought that this only mattered for external packages. Do you expect people to 
use a 3.7-compiled posixmodule.c on Python 3.8?

--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-01-07 Thread STINNER Victor 


Change by STINNER Victor :


--
title: Heap-allocated posixmodule types -> posixmodule: convert statically 
allocated types (DirEntryType & ScandirIteratorType) to heap-allocated  types

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com