[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: Aye, we can :) -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35486] subprocess module import hooks breaks back compatibility

Ned Deily added the comment: I've merged the doc changes for 3.6, thanks. Can we close this now? -- ___ Python tracker ___ ___

[issue35486] subprocess module import hooks breaks back compatibility

Ned Deily added the comment: New changeset 1edb3dc6ff70db88a7e89586578e58a86ee0e75e by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-35486: Note Py3.6 import system API requirement change (GH-11540) (GH-11588)

[issue35486] subprocess module import hooks breaks back compatibility

miss-islington added the comment: New changeset 422db3777874f4f31fc8f4e718f440a2abc59347 by Miss Islington (bot) in branch '3.7': bpo-35486: Note Py3.6 import system API requirement change (GH-11540) https://github.com/python/cpython/commit/422db3777874f4f31fc8f4e718f440a2abc59347

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11279, 11280, 11281, 11282, 11283 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11278, 11279, 11280 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11279, 11280, 11281, 11283 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11279, 11280, 11283 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35486] subprocess module import hooks breaks back compatibility

miss-islington added the comment: New changeset cee29b46a19116261b083dc803217aa754c7df40 by Miss Islington (bot) (Nick Coghlan) in branch 'master': bpo-35486: Note Py3.6 import system API requirement change (GH-11540)

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11278, 11279 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11278 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: dw: we routinely impose new requirements on folks modifying runtime internals in new feature releases, so the only aspect we missed for this changing is to explicitly call it out in the Porting section of the Python 3.6 What's New document as a potential

[issue35486] subprocess module import hooks breaks back compatibility

Change by Nick Coghlan : -- keywords: +patch, patch pull_requests: +11147, 11148 stage: test needed -> patch review ___ Python tracker ___

[issue35486] subprocess module import hooks breaks back compatibility

Change by Nick Coghlan : -- keywords: +patch, patch, patch pull_requests: +11147, 11148, 11149 stage: test needed -> patch review ___ Python tracker ___

[issue35486] subprocess module import hooks breaks back compatibility

Change by Nick Coghlan : -- keywords: +patch pull_requests: +11147 stage: test needed -> patch review ___ Python tracker ___ ___

[issue35486] subprocess module import hooks breaks back compatibility

David Wilson added the comment: Hi Nick, The purpose of ModuleNotFoundError is clear and unrelated to the problem documented here. The problem is that due to the introduction of ModuleNotFoundError, ImportError's semantics have been changed within a minor release in a breaking,

[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: Note that the above distinction is also the rationale for introducing the new subtype: so that it's easy to tell the difference between "that module was not found at all" (ModuleNotFoundError) and "the module was found, but attempting to actually load it

[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: The two errors mean different things: ModuleNotFoundError means literally that the module could not be found at all (i.e. no import hook offered to try to load it) A plain ImportError then means that the module was located, but attempting to actually load it

[issue35486] subprocess module import hooks breaks back compatibility

Brett Cannon added the comment: RE: "PEP-302 and PEP-451 are the definitive specifications for how sys.meta_path is supposed to work" That's actually not true. In the case of import the language reference is considered the reference for import:

[issue35486] subprocess module import hooks breaks back compatibility

Change by Terry J. Reedy : -- nosy: +brett.cannon, eric.snow, ncoghlan stage: -> test needed title: subprocess module breaks backwards compatibility with import hooks -> subprocess module import hooks breaks back compatibility type: -> behavior