[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Ned Deily added the comment: New changeset 7e4e4bd2b8245426fe733f3c57238acf41f17900 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) (GH-11179)

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by Ned Deily : -- pull_requests: -10503 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by STINNER Victor : -- pull_requests: +10503 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by Ned Deily : -- pull_requests: -10497 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Ned Deily added the comment: New changeset 782e1d537778d93eb4cba1343f71bfc51e7e3c00 by Ned Deily (Victor Stinner) in branch '3.6': bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) (GH-11267) https://github.com/python/cpython/commit/782e1d537778d93eb4cba1343f71bfc51e7e3c00

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by STINNER Victor : -- pull_requests: +10498 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by STINNER Victor : -- pull_requests: +10497 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

STINNER Victor added the comment: > (...) things like PGO often require flags that the linker sees in order to > generate the instrumented binary. If those are left off of the link step, you > won't have an instrumented binary and won't generate profile data. Oh, I didn't try my PR... $

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Gregory P. Smith added the comment: But the `build_all_generate_profile` build is an intermediate instrumented interpreter build, it isn't shipped and things like PGO often require flags that the linker sees in order to generate the instrumented binary. If those are left off of the link

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by STINNER Victor : -- pull_requests: +10455 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

STINNER Victor added the comment: Oh wait, "make build_all_generate_profile" and "make profile-opt" have another issue. They modify LDFLAGS, whereas PGO flags seem to be very specific to the compiler, not to the linker. I reopen the issue. build_all_generate_profile: $(MAKE)

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

STINNER Victor added the comment: New changeset 9a4758550d96030ee7e7f7c7c68b435db1a2a825 by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) (GH-11179)

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by miss-islington : -- pull_requests: +10419 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

STINNER Victor added the comment: New changeset 640ed520dd6a43a8bf470b79542f58b5d57af9de by Victor Stinner in branch 'master': bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) https://github.com/python/cpython/commit/640ed520dd6a43a8bf470b79542f58b5d57af9de --

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

STINNER Victor added the comment: I also tested CFLAGS, just in case. Current behavior: $ git clean -fdx $ ./configure --with-pydebug $ make profile-opt CFLAGS="-O1" (...) gcc -pthread -c -Wno-unused-result -Wsign-compare -g -Og -Wall -O1 -std=c99 -Wextra -Wno-unused-result

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

STINNER Victor added the comment: I wrote PR 11164 to fix the issue. Example: $ git clean -fdx $ ./configure --with-pydebug $ make profile-opt CFLAGS_NODIST="-O1" (...) gcc -pthread -c -Wno-unused-result -Wsign-compare -g -Og -Wall-std=c99 -Wextra -Wno-unused-result

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

Change by STINNER Victor : -- keywords: +patch pull_requests: +10400 stage: -> patch review ___ Python tracker ___ ___

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

New submission from STINNER Victor : Makefile.pre.in contains the rule: build_all_generate_profile: $(MAKE) @DEF_MAKE_RULE@ CFLAGS_NODIST="$(CFLAGS) $(PGO_PROF_GEN_FLAG)" LDFLAGS="$(LDFLAGS) $(PGO_PROF_GEN_FLAG)" LIBS="$(LIBS)" I'm not sure that CFLAGS_NODIST="$(CFLAGS)