[issue35668] Improve test coverage for idlelib

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- nosy: +anthonypjshaw ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35668] Improve test coverage for idlelib

2019-01-08 Thread anthony shaw
Change by anthony shaw : -- pull_requests: +10972 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35668] Improve test coverage for idlelib

2019-01-08 Thread anthony shaw
Change by anthony shaw : -- pull_requests: +10972, 10973 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35668] Improve test coverage for idlelib

2019-01-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: I moved the debugger tests to #35690. I want to keep this issue for general discussion of testing IDLE, and possibly related PRs improving the documentation thereof. Serhiy Storchaka, the current tkinter maintainer, and I, have decided that IDLE should

[issue35668] Improve test coverage for idlelib

2019-01-08 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: -10913 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: I like having multiple commits with explanatory messages. They get squashed when merging into master. Unless I get distracted and forget, I will squash the messages. -- ___ Python tracker

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: -10914 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: -10915 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: -10916 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch, patch, patch pull_requests: +10913, 10914, 10916 stage: -> patch review ___ Python tracker ___

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch, patch, patch, patch pull_requests: +10913, 10914, 10915, 10916 stage: -> patch review ___ Python tracker ___

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch, patch pull_requests: +10913, 10914 stage: -> patch review ___ Python tracker ___ ___

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch pull_requests: +10913 stage: -> patch review ___ Python tracker ___ ___

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread anthony shaw
anthony shaw added the comment: thanks Cheryl, here's my branch https://github.com/tonybaloney/cpython/tree/idlelib_tests I've already seen some code which is 17 years old! -- ___ Python tracker

[issue35668] Improve test coverage for idlelib

2019-01-06 Thread Cheryl Sabella
Cheryl Sabella added the comment: Welcome Anthony! Please ask me any questions you may have. My only suggestion at this point would be for you to feel free to add any docstrings/comments to the module as you go. Having the docstrings really helps in understanding the tests and vice

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: I like that choice. There are 15 open issues for debugger and I have notes on a few possible enhancements. -- ___ Python tracker ___

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread anthony shaw
anthony shaw added the comment: I was looking at the debugger.py module as being a good place the start, writing test cases for the Idb, Debugger, StackViewer and NamespaceViewer by patching out the dependant components (bdb, Idb, etc. I might start there, raise a PR against it and do a

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great. I suggest then that you start with untested, normal, non-GUI (non-tkinter) code, assuming that you can find some. This can mean segregating functional code from gui code if they are currently intertwined. As point 1 above suggested, IDLE, which

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread anthony shaw
anthony shaw added the comment: thanks terry, Some great pointers there, I'll review the exiting work and the README doc. With regards to my experience, I have quite extensive experience with python testing. Most of which would be open-source on my Github profile

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: I (we) agree that idlelib needs even better test coverage. Some history: 1. I added idle_test/ 5-1/2 years ago. Only the calltip module had automated tests easily converted to unittests (test_calltip). 2. Other exiting tests, requiring human judgement, were