[issue36003] set better defaults for TCPServer options

[Tal Einat]

Tal Einat  added the comment:

I'm not sure that changing the default value for "reuse address" justifies 
breaking backwards compatibility like this. Admittedly, I'm not an expert on 
networking, so perhaps there's a good reason that I'm unaware of.

As for the queue size, passing 0 to socket.listen() does seem like a more 
reasonable default than the rather arbitrary value of 5. Again, it's arguable 
whether it's worth changing this given that it has been like this for a long 
time, but in this case at least the potential for harm seems negligible.

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36003] set better defaults for TCPServer options

[Giampaolo Rodola']

Change by Giampaolo Rodola' :


--
keywords: +patch
pull_requests: +11908
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36003] set better defaults for TCPServer options

[Giampaolo Rodola']

Giampaolo Rodola'  added the comment:

Update: because "request_queue_size" is passed to server_activate() method 
which can be subclassed, a better default for not breaking backward 
compatibility is 0 (not None).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36003] set better defaults for TCPServer options

[Giampaolo Rodola']

New submission from Giampaolo Rodola' :

socketserver.TCPServer provides the following defaults:

allow_reuse_address = False
request_queue_size = 5

Proposal is to:
* have "allow_reuse_address = True" on POSIX in order to immediately reuse 
previous sockets which were bound on the same address and remained in TIME_WAIT 
state
* have "request_queue_size = None" so that it's up to socket.listen() to choose 
a default reasonable value (usually 128)

--
components: Library (Lib)
keywords: easy
messages: 335612
nosy: asvetlov, giampaolo.rodola, neologix, yselivanov
priority: normal
severity: normal
status: open
title: set better defaults for TCPServer options
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com