[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: > The default build of python with ASAN builds successfully. Test suite and PGO > build are currently blocked, but that can be separated if it makes more sense > to handle them individually. Yeah, please open one issue per ASAN issue (try to group similar

[issue36356] Failure to build with address sanitizer

Change by Yury Selivanov : -- nosy: -yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Ben Harper added the comment: The default build of python with ASAN builds successfully. Test suite and PGO build are currently blocked, but that can be separated if it makes more sense to handle them individually. Would it make sense to add an ASAN build to the CI pipeline to make

[issue36356] Failure to build with address sanitizer

Ned Deily added the comment: FWIW, the assertion error on macOS reported above in msg338774 does not seem to occur anymore with current HEAD of master and with recent system clang (Apple clang version 11.0.0 (clang-1100.0.33.8)) on macOS 10.14.6. --

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: Can we close this issue, or is there a remaining known bug? -- ___ Python tracker ___ ___

[issue36356] Failure to build with address sanitizer

miss-islington added the comment: New changeset 13915a3100608f011b29da2f3716c990f523b631 by Miss Islington (bot) in branch '3.8': bpo-36356: Fix memory leak in _asynciomodule.c (GH-16598) https://github.com/python/cpython/commit/13915a3100608f011b29da2f3716c990f523b631 -- nosy:

[issue36356] Failure to build with address sanitizer

Change by miss-islington : -- pull_requests: +16209 pull_request: https://github.com/python/cpython/pull/16622 ___ Python tracker ___

[issue36356] Failure to build with address sanitizer

Yury Selivanov added the comment: New changeset 321def805abc5b7c92c7e90ca90cb2434fdab855 by Yury Selivanov (Ben Harper) in branch 'master': bpo-36356: Fix memory leak in _asynciomodule.c (GH-16598) https://github.com/python/cpython/commit/321def805abc5b7c92c7e90ca90cb2434fdab855 --

[issue36356] Failure to build with address sanitizer

Change by Ben Harper : -- pull_requests: +16186 pull_request: https://github.com/python/cpython/pull/16598 ___ Python tracker ___

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: I just reverted the change. I'm unable to reproduce and I am not available this week to investigate anyway. -- ___ Python tracker ___

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset 99fcc616d400cd31af0733c3f8cc93bcc1d32a44 by Victor Stinner in branch 'master': Revert "bpo-36356: Destroy the GIL at exit (GH-12453)" (GH613006) https://github.com/python/cpython/commit/99fcc616d400cd31af0733c3f8cc93bcc1d32a44 --

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12927 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: Oh. test_daemon_threads_shutdown_stdout_deadlock of test_io fails randomly on buildbots. I ran "./python -m test test_io -m '*daemon*' -F -j4" for 5 minutes on my Fedora 29 before merging my PR, but I didn't get any failure :-(

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset b36e5d627d4232a01850707eb78a5067f3fd77f4 by Victor Stinner in branch 'master': bpo-36356: Destroy the GIL at exit (GH-12453) https://github.com/python/cpython/commit/b36e5d627d4232a01850707eb78a5067f3fd77f4 --

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: The initial issue has been fixed, so I close the issue. I prefer to get more specific issues like bpo-36724 "Clear _PyRuntime at exit" to following changes. Thanks Ben Harper for the bug report and the fix. Note: Ben, I like your songs! Good to know that

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: See also bpo-36724 "Clear _PyRuntime at exit". -- ___ Python tracker ___ ___ Python-bugs-list

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset 4cb525a1f0cba152d1da61e531f2ad5db633120a by Victor Stinner in branch 'master': bpo-36356: pymain_exit_error() only call pymain_free() for exit (GH-12968) https://github.com/python/cpython/commit/4cb525a1f0cba152d1da61e531f2ad5db633120a

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12895 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Stéphane Wirtel added the comment: @Ned, I have found a solution on Linux, will try on this evening with my macOS laptop. I hope to come with a solution on this evening or tomorrow, but need to check my proto. -- ___ Python tracker

[issue36356] Failure to build with address sanitizer

Ben Harper added the comment: I'm not sure about the change from 3.7 to master, but that assertion may be more likely to happen while instrumented with ASAN due to the extra space reserved between heap objects. As far as I can tell it's just expecting that the offset of two pointers will

[issue36356] Failure to build with address sanitizer

Ned Deily added the comment: For what it's worth, with current HEAD of master (commit 62be33870e2f8517314bf9c7275548e799296f7e which includes previously merged PRs from this issue), current macOS clang with address sanitizer and pydebug enabled gets an assertion failure in parsetok.c.

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset 4a1468e593c4b67d8c78b78070fff9e18ec5d790 by Victor Stinner in branch 'master': bpo-36356: Fix _PyCoreConfig_Read() (GH-12454) https://github.com/python/cpython/commit/4a1468e593c4b67d8c78b78070fff9e18ec5d790 --

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12407 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12406 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Change by Ben Harper : -- pull_requests: +12399 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Ben Harper added the comment: I'm on Ubuntu 18.10/amd64 compiling with Ubuntu's GCC 8.2.0, I know there's some libraries that are missing dependencies (including bz2 and sqlite) so I may have missed the ipv6 dependencies as well. My eventual goal was to be able to build a pgo optimized

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: At least, "./python -V" no longer leaks at commit dcf617152e1d4c4a5e7965733928858a9c0936ca. $ ./configure --with-valgrind $ make $ valgrind ./python -V ==9553== Memcheck, a memory error detector ==9553== Copyright (C) 2002-2017, and GNU GPL'd, by Julian

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset 935250d6f3ac7ba91e1ea8e6ca63aaf7f605e291 by Victor Stinner in branch '3.7': bpo-36356: pymain_free() calls _PyRuntime_Finalize() (GH-12436) https://github.com/python/cpython/commit/935250d6f3ac7ba91e1ea8e6ca63aaf7f605e291 --

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset f5f336a819a3d881bb217bf8f9b5cacba03a4e45 by Victor Stinner in branch 'master': bpo-36356: pymain_free() calls _PyRuntime_Finalize() (GH-12435) https://github.com/python/cpython/commit/f5f336a819a3d881bb217bf8f9b5cacba03a4e45 --

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12391 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12390 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset a712679a2befaacdc05f788d6ea50f72a561 by Victor Stinner in branch 'master': bpo-36333, bpo-36356: Fix _PyEval_FiniThreads() (GH-12432) https://github.com/python/cpython/commit/a712679a2befaacdc05f788d6ea50f72a561 --

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset fecc4f2b474f16062514e95a67e66080fd626e14 by Victor Stinner in branch 'master': bpo-36356: Release Unicode interned strings on Valgrind (#12431) https://github.com/python/cpython/commit/fecc4f2b474f16062514e95a67e66080fd626e14 --

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12387 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Change by STINNER Victor : -- pull_requests: +12385 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

STINNER Victor added the comment: New changeset e130a07eb20c4b655d182d5d10d778c7584efe55 by Victor Stinner (btharper) in branch 'master': bpo-36356: Fix memory leak in _PyPreConfig_Read() (GH-12425) https://github.com/python/cpython/commit/e130a07eb20c4b655d182d5d10d778c7584efe55

[issue36356] Failure to build with address sanitizer

Stéphane Wirtel added the comment: your PR seems to be fine. but I continue to get two refleaks with valgrind but don't worry, @vstinner is working on these refleaks. ==5440== 64 bytes in 1 blocks are possibly lost in loss record 1 of 2 ==5440==at 0x483880B: malloc

[issue36356] Failure to build with address sanitizer

Stéphane Wirtel added the comment: ok, found I have to disable ipv6 and install libasan ./python -E -S -m sysconfig --generate-posix-vars ;\ if test $? -ne 0 ; then \ echo "generate-posix-vars failed" ; \ rm -f ./pybuilddir.txt ; \ exit 1 ; \ fi

[issue36356] Failure to build with address sanitizer

Stéphane Wirtel added the comment: just for me, btharper, which system do you use? because I have a fedora 29 and when I try to compile with these flags, getaddrinfo is not found. -- nosy: +matrixise ___ Python tracker

[issue36356] Failure to build with address sanitizer

Change by Karthikeyan Singaravelan : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36356] Failure to build with address sanitizer

Change by Ben Harper : -- keywords: +patch pull_requests: +12380 stage: -> patch review ___ Python tracker ___ ___

[issue36356] Failure to build with address sanitizer

New submission from Ben Harper : Trying to run make after './configure --with-address-sanitizer --with-pydebug' fails with leak of locale string -- components: Build messages: 338315 nosy: btharper priority: normal severity: normal status: open title: Failure to build with address