[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Serhiy Storchaka added the comment: It is not good first issue. The referred documentation is complex and needs deep knowledge of Python for changing. The original report was wrong. The original documentation is correct. Josh, do you think the documentation needs other changes, and if yes,

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Ido Michael added the comment: Hey, Is someone working on this issue? Can I take it? Ido -- nosy: +Ido Michael ___ Python tracker ___

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Change by Roundup Robot : -- keywords: +patch pull_requests: +15037 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15319 ___ Python tracker ___

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Chirag Garg added the comment: It should be written like "In the following example, both MyClass and MySubclass are instances of Meta and the type of MyClass is of metaclass Meta and type of MySubclass is MyClass:" -- nosy: +codevil_2o ___ Python

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Josh Rosenberg added the comment: Ah, you're right on __call__; I've never bothered to override it on a metaclass, but yes, since a class using a metaclass is an instance of the metaclass, like all instances, calling it invokes the __call__ of its type (it's just that the default metaclass,

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Nicholas Matthews added the comment: Thanks for the clarification. For the first point on the correctness of the original text, that makes sense, could you link me to any relevant documentation for further reading? On the second point "Meta modifies the creation of the classes themselves,

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Josh Rosenberg added the comment: Clarification is fine, but "MyClass and MySubclass are instances of Meta:" is 100% true. Declaring a class to have a metaclass (or inheriting from a class with a metaclass) means that the class itself is an instance of the metaclass. New instances of the

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Nicholas Matthews added the comment: Ok, I will create a PR soon and update the issue. -- ___ Python tracker ___ ___

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Stéphane Wirtel added the comment: If you want to modify the text, please create a PR for this file: https://github.com/python/cpython/blob/master/Doc/reference/datamodel.rst#metaclasses Don't forget to sign the CLA, Thank you -- ___ Python

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Stéphane Wirtel added the comment: Found here: https://docs.python.org/3/reference/datamodel.html#metaclasses Thank you -- status: pending -> open ___ Python tracker ___

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Stéphane Wirtel added the comment: just one question, I don't find the paragraph with this text in the code. Could you share the link of this paragraph? Thank you -- status: open -> pending ___ Python tracker

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

Change by Stéphane Wirtel : -- keywords: +easy title: Fix 3.3.3.1 Metaclasses Documentation -> [Good first issue] Fix 3.3.3.1 Metaclasses Documentation ___ Python tracker ___