Roundup Robot devnull@devnull added the comment:
New changeset 25298224cb25 by Senthil Kumaran in branch 'default':
Issue #3709: a flush_headers method to BaseHTTPRequestHandler which manages the
http://hg.python.org/cpython/rev/25298224cb25
--
nosy: +python-dev
Senthil Kumaran sent...@uthcode.com added the comment:
Added the flush_headers method and the test function. this issue can be closed
now. Thanks, Andrew Schaaf.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
Senthil Kumaran orsent...@gmail.com added the comment:
Fixed this revision 86640.
- Even though this is an internal optimization,I don't think back-porting is a
good idea, because it changes the behavior of certain methods like send_header
and end_headers
- Added the Documentation and other
R. David Murray rdmur...@bitdance.com added the comment:
Senthil, I didn't clearly express my concern about send_response_only. It
doesn't look to me like, with buffering in place, that it *should* write
directly, it looks to me like it should write to the buffer. Consider
specifically the
Senthil Kumaran orsent...@gmail.com added the comment:
On Sun, Nov 21, 2010 at 03:15:06PM +, R. David Murray wrote:
Senthil, I didn't clearly express my concern about
send_response_only. It doesn't look to me like, with buffering in
place, that it *should* write directly, it looks to me
Andrew Schaaf and...@andrewschaaf.com added the comment:
This patch (to 86665)...
* adds buffering to send_response_only
* adds flush_headers and uses it in end_headers and
CGIHTTPRequestHandler.run_cgi
* tests {send_error,send_response_only,send_header} using a write-counting wfile
* improves
endian and...@andrewschaaf.com added the comment:
How about this patch?
--
keywords: +patch
nosy: +endian
Added file: http://bugs.python.org/file19689/issue3709.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
Changes by Éric Araujo mer...@netwok.org:
--
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
___
Python-bugs-list
R. David Murray rdmur...@bitdance.com added the comment:
It looks good, but as mentioned on IRC it would be nice to have a unit test
that confirmed that the headers were being correctly buffered.
--
nosy: +r.david.murray
___
Python tracker
endian and...@andrewschaaf.com added the comment:
Working on it...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
___
Python-bugs-list
Changes by endian and...@andrewschaaf.com:
Added file: http://bugs.python.org/file19692/issue3709.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
endian and...@andrewschaaf.com added the comment:
Ready for review. Added test_header_buffering which fails without the
BaseHTTPRequestHandler patch and passes with it.
--
Added file: http://bugs.python.org/file19704/issue3709.diff
___
Python
Changes by endian and...@andrewschaaf.com:
Removed file: http://bugs.python.org/file19689/issue3709.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
Changes by endian and...@andrewschaaf.com:
Removed file: http://bugs.python.org/file19692/issue3709.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
Bruno Gola brunog...@gmail.com added the comment:
applied the patch on py3k on trunk and everything seems fine (works here)
--
nosy: +brunogola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
R. David Murray rdmur...@bitdance.com added the comment:
Thanks for the patch and test. They look good.
A doc update is also needed, since the docs are currently written in such a way
that buffering the header lines makes the documentation no longer true.
Also, send_response_only writes
Changes by R. David Murray rdmur...@bitdance.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
___
Terry J. Reedy tjre...@udel.edu added the comment:
Does this issue apply to 3.1/2?
--
nosy: +tjreedy
versions: +Python 2.7 -Python 2.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
Senthil Kumaran orsent...@gmail.com added the comment:
Yes, it is applicable to 3.1 and 3.2 as well. This is definitely a good to have
performance improvement.
--
nosy: +orsenthil
versions: +Python 3.1, Python 3.2
___
Python tracker
New submission from Yang Zhao [EMAIL PROTECTED]:
send_header() in BaseHTTPRequestHandler currently does a write to socket
every time send_header() is called. This results in excessive number of
TCP packets being regenerated. Ideally, as much of the HTTP packet is
buffered as possible, but, at
21 matches
Mail list logo
