[issue37191] Python.h contains intermingled declarations

STINNER Victor added the comment: Petr Viktorin fixed the issue, thanks ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker

[issue37191] Python.h contains intermingled declarations

STINNER Victor added the comment: New changeset 9689f80e61e5863668a562793ebb85031ef9fd3e by Victor Stinner (Petr Viktorin) in branch '3.8': bpo-37191: Avoid declaration-after-statement in header included from Python.h (GH-13887)

[issue37191] Python.h contains intermingled declarations

miss-islington added the comment: New changeset 5effd10bf14ab0a8a6695100aaf0b687eca68e6d by Miss Islington (bot) in branch '3.8': bpo-37191: Move TestPEP590 from test_capi to test_call (GH-13892) https://github.com/python/cpython/commit/5effd10bf14ab0a8a6695100aaf0b687eca68e6d --

[issue37191] Python.h contains intermingled declarations

STINNER Victor added the comment: > I've removed -Wdeclaration-after-statement in upstream pygobject: > https://gitlab.gnome.org/GNOME/pygobject/merge_requests/119 Thanks! Enjoy C99! :-) IMHO C99 with variables in the middle of a function helps to write more reliable code: we better control

[issue37191] Python.h contains intermingled declarations

Change by miss-islington : -- pull_requests: +13772 pull_request: https://github.com/python/cpython/pull/13897 ___ Python tracker ___

[issue37191] Python.h contains intermingled declarations

STINNER Victor added the comment: New changeset 740a84de73ad8d02655de0a084036f4b7e49a01b by Victor Stinner in branch 'master': bpo-37191: Move TestPEP590 from test_capi to test_call (GH-13892) https://github.com/python/cpython/commit/740a84de73ad8d02655de0a084036f4b7e49a01b --

[issue37191] Python.h contains intermingled declarations

Christoph Reiter added the comment: I've removed -Wdeclaration-after-statement in upstream pygobject: https://gitlab.gnome.org/GNOME/pygobject/merge_requests/119 -- nosy: +lazka ___ Python tracker

[issue37191] Python.h contains intermingled declarations

Change by STINNER Victor : -- pull_requests: +13766 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13892 ___ Python tracker ___

[issue37191] Python.h contains intermingled declarations

Jeroen Demeyer added the comment: > It's well within our rights to ignore this: since 3.6 we require intermingled > declarations. It's not clear from PEP 7 if we require intermingled declarations only when compiling CPython itself, or also for external packages that include CPython

[issue37191] Python.h contains intermingled declarations

Jeroen Demeyer added the comment: Should we revert these inline functions back to macros? -- nosy: +jdemeyer ___ Python tracker ___

[issue37191] Python.h contains intermingled declarations

STINNER Victor added the comment: PR 13887 is fine but I would prefer to still be able to use C99 style for variable declarations. More generally, I don't think that variable declaration is the only issue: static inline function is a new shiny thing which can cause other issues with some C

[issue37191] Python.h contains intermingled declarations

Petr Viktorin added the comment: > pygobject3, python-dbus, xen Correction: - The Fedora packages failed to build; this might or might not be due to the projects themseves - pygobject3 actually only warns on this Anyway, we can usually take care of open-source stuff. Only take it as a

[issue37191] Python.h contains intermingled declarations

Change by Petr Viktorin : -- keywords: +patch pull_requests: +13761 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13887 ___ Python tracker ___

[issue37191] Python.h contains intermingled declarations

New submission from Petr Viktorin : When compiled with GCC's -Werror=declaration-after-statement ("intermingled declarations" in PEP7), cpython/abstract.h (included from ) errors on vectorcall helper functions added in 3.8.0 Beta 1. It's well within our rights to ignore this: since 3.6 we