Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
This second patch is good and does fix the error.
--
keywords: -needs review
resolution: - accepted
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3807
STINNER Victor victor.stin...@haypocalc.com added the comment:
I don't understand the usage of _save argument of conn_poll() function
(of the _multiprocessing module). Here is a patch to remove it. I first
wrote this patch to try to compile _multiprocessing without thread
support (which is
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
_save is used, by the Py_BLOCK_THREADS macros.
(when threads are enabled, of course).
I think that you should not try to compile _multiprocessing without
threads enabled. multiprocessing does need multiple threads to work.
Jesse Noller jnol...@gmail.com added the comment:
Amaury is correct - without thread support, a lot of mp internals will
yak, so we're just going to disable it
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3807
Jesse Noller jnol...@gmail.com added the comment:
my patch is in py3k as 68875 and trunk as r68874
--
resolution: accepted - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3807
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file:
http://bugs.python.org/file12841/_multiprocessing_remove_save.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3807
___
Changes by Jesse Noller jnol...@gmail.com:
--
assignee: - jnoller
nosy: +jnoller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3807
___
___
Changes by Hirokazu Yamamoto [EMAIL PROTECTED]:
--
keywords: +needs review
versions: +Python 3.0
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3807
___
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
The patch is not easy to read, but if it can be summarized to:
if sysconfig.get_config_var('WITH_THREAD'):
build the _multiprocessing extension
else:
missing.append('_multiprocessing')
then this makes sense - it
Martin v. Löwis [EMAIL PROTECTED] added the comment:
Why is this a release blocker? If you configure without threads, you get
a few ugly compiler messages, but Python still builds exactly the same
way as without this patch, right?
So if the patch doesn't make it into 2.6, it can still be
New submission from Hirokazu Yamamoto [EMAIL PROTECTED]:
I'm not sure how to fix this, (or even should fix this) when configure
--without-threads, error message is not pretty. This happens at trunk,
but probably same thing would happen at py3k.
gcc -shared -Wl,--enable-auto-image-base
11 matches
Mail list logo
