[issue38120] DeprecationWarning in test_random due to invalid seed arguments

Serhiy Storchaka added the comment: New changeset a06d683d7fd88721eaf59abcf5b02eb82045c7b1 by Serhiy Storchaka (Xtreak) in branch 'master': bpo-38120: Fix DeprecationWarning in test_random for invalid type of arguments to random.seed. (GH-15987)

[issue38120] DeprecationWarning in test_random due to invalid seed arguments

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38120] DeprecationWarning in test_random due to invalid seed arguments

Raymond Hettinger added the comment: Okay. This looks good to go. I don't remember why the original test repeated some of the seeds -- that would normally only be done if caching was present. -- assignee: rhettinger -> xtreak ___ Python tracker

[issue38120] DeprecationWarning in test_random due to invalid seed arguments

STINNER Victor added the comment: I confirm that test_random currently fails using -Werror: $ ./python -W error -m test -v test_random == ERROR: test_seed_when_randomness_source_not_found

[issue38120] DeprecationWarning in test_random due to invalid seed arguments

Karthikeyan Singaravelan added the comment: Sure, I think these were not caught since deprecation warnings are not shown as part of CI as failure. I just caught them at the sprint running with -Wall. -- ___ Python tracker

[issue38120] DeprecationWarning in test_random due to invalid seed arguments

Raymond Hettinger added the comment: Thanks for doing this. If you don't mind, let's hold off one day so I can take a closer look at this when I get home tonight. -- assignee: -> rhettinger ___ Python tracker

[issue38120] DeprecationWarning in test_random due to invalid seed arguments

Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +15616 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15987 ___ Python tracker

[issue38120] DeprecationWarning in test_random due to invalid seed arguments

New submission from Karthikeyan Singaravelan : Since d0cdeaab76fef8a6e5a04665df226b6659111e4e (bpo-32554) using random.seed raises DeprecationWarning for some types. This is not handled in test_random causing DeprecationWarnings. I will raise a PR for this. commit