[issue38708] parse_message_id in email module is very buggy / crashy

Abhilash Raj added the comment: Closing this as fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38708] parse_message_id in email module is very buggy / crashy

miss-islington added the comment: New changeset 2abd3a8f580e6c7b1ce88b2ae9f9a783f4aea5d3 by Miss Islington (bot) in branch '3.8': bpo-38708: email: Fix a potential IndexError when parsing Message-ID (GH-17504) https://github.com/python/cpython/commit/2abd3a8f580e6c7b1ce88b2ae9f9a783f4aea5d3

[issue38708] parse_message_id in email module is very buggy / crashy

Change by miss-islington : -- pull_requests: +16992 pull_request: https://github.com/python/cpython/pull/17515 ___ Python tracker ___

[issue38708] parse_message_id in email module is very buggy / crashy

Abhilash Raj added the comment: New changeset 3ae4ea1931361dd2743e464790e739d9285501bf by Abhilash Raj in branch 'master': bpo-38708: email: Fix a potential IndexError when parsing Message-ID (GH-17504) https://github.com/python/cpython/commit/3ae4ea1931361dd2743e464790e739d9285501bf

[issue38708] parse_message_id in email module is very buggy / crashy

Change by Abhilash Raj : -- keywords: +patch pull_requests: +16981 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17504 ___ Python tracker ___

[issue38708] parse_message_id in email module is very buggy / crashy

Change by Karthikeyan Singaravelan : -- components: +email nosy: +barry, maxking, r.david.murray type: -> behavior ___ Python tracker ___

[issue38708] parse_message_id in email module is very buggy / crashy

Dimitri John Ledkov added the comment: Yes, issue38698 covers the UnboundLocalError, but doesn't cover inside get_msg_id there is also this gem: def get_msg_id(value): msg_id = MsgID() if value[0] in CFWS_LEADER: It should test value before accessing value[0] like it is

[issue38708] parse_message_id in email module is very buggy / crashy

Karthikeyan Singaravelan added the comment: This seems to be the same as issue38698. -- nosy: +xtreak ___ Python tracker ___ ___

[issue38708] parse_message_id in email module is very buggy / crashy

New submission from Dimitri John Ledkov : email module has recently got parse_message_id which is more strict now, then before. However, it's not programmed as defensively as expected. Given bogus message-id, it crashes with unbound local variable, or like accessing a non-existing index.